Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elements go outside the window at a small width #14713

Open
Ruslan-Aleev opened this issue Sep 3, 2019 · 5 comments

Comments

@Ruslan-Aleev
Copy link
Contributor

commented Sep 3, 2019

Bug report

Summary

Many elements are cropped by the window if the width is not enough.

grid_1

grid_2

grid_3

The problem, it seems to me, is that extJS builds a template with tables that are difficult to adapt based on the width.

Environment

MODX 2>

@Mark-H

This comment has been minimized.

Copy link
Collaborator

commented Sep 3, 2019

Any ideas on how this could be resolved?

@JoshuaLuckers

This comment has been minimized.

Copy link
Collaborator

commented Sep 3, 2019

Maybe it's possible by creating a new Ext.Template that doesn't use tables for rendering the toolbar(s)?

@Ruslan-Aleev

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

Another option is to make this style relevant for larger widths - https://github.com/Ruslan-Aleev/revolution/blob/ba313b588035e9e284939136489ef29314bdb0bf/_build/templates/default/sass/index.scss#L295
But this is too too serious edits and may affect other table elements...

@JoshuaLuckers

This comment has been minimized.

Copy link
Collaborator

commented Sep 3, 2019

If we can't define a custom Ext.Tempalte for the toolbar maybe we can force the table element (and child elements) to behave like be a block element.

Inspired by "Responsive Data Tables"

@Ruslan-Aleev

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

The my link above is about the same (behave like be a block element). I can redo some styles and the styles will be like this:

grid_4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.