New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minifier doesn't work with manager on different subdomain #9282

Closed
modxbot opened this Issue Dec 15, 2012 · 1 comment

Comments

Projects
None yet
2 participants
@modxbot

modxbot commented Dec 15, 2012

danya_postfactum created Redmine issue ID 9282

I have defined MODX_MANAGER_URL as '/' and moved manager to http://manager.site.com. It works with disabled minifier. When I enable it, I get 400 (Bad Request) error from manager/min/index.php . This is because of line 58:

$hasVirtualManagerURL = empty($min_documentRoot) || strpos(MODX_MANAGER_PATH, $min_documentRoot) !== 0 || strpos(MODX_MANAGER_PATH, MODX_MANAGER_URL) === false || substr(MODX_MANAGER_PATH, 0, strpos(MODX_MANAGER_PATH, MODX_MANAGER_URL)) !== $min_documentRoot;

This does not works with '/' MODX_MANAGER_URL. The solution is changing the second and the third strpos functions to strrpos. Same with MODX_ASSETS_URL, I suppose, since it can be placed on differend subdomain.

@opengeek

This comment has been minimized.

Show comment
Hide comment
@opengeek

opengeek Feb 21, 2013

Member

opengeek submitted:

#444

Member

opengeek commented Feb 21, 2013

opengeek submitted:

#444

enigmatic-user pushed a commit to enigmatic-user/revolution that referenced this issue Feb 13, 2014

enigmatic-user pushed a commit to enigmatic-user/revolution that referenced this issue Feb 13, 2014

[modxcms#9282] Fix Minify errors when manager on different subdomain
Merge branch 'bug-9282' into release-2.2

* bug-9282:
  [modxcms#9282] changelog update
  Fix for MANAGER_URL == '/'

danyaPostfactum pushed a commit to danyaPostfactum/revolution that referenced this issue Mar 26, 2014

Merge branch 'release-2.2' into develop
* release-2.2: (33 commits)
  Allow modX::getParser() to get an extended modParser instance
  Update core/model/modx/modx.class.php
  [modxcms#9524] changelog entry
  Small fix that clears errors on sites with mupltiple contexts. Sometimes array $modx->contexts get wrong key=>object assigment cause of switchContext don't fill $this->contexts array, but links it to $this->context.
  [modxcms#9517] changelog entry
  [modxcms#9451] changelog entry
  add changelog entry
  Increase width of file and image TVs (changelog entry)
  [modxcms#9282] changelog update
  Translated new phrases in configcheck.inc.php and setting.inc.php to German.
  Update changelog for Various UI Fixes
  [9517] - See http://tracker.modx.com/issues/9517
  [9451] - See http://tracker.modx.com/issues/9451
  [modxcms#6150] Fix issues with auto_publish when encountering invalid data
  Add title with name to thumb div
  Increase width of file and image TVs
  Give the MODx.Browser some TLC. - Increased thumb size to 100x80 - Give detail panel some more room - Fix annoying jumpiness of images
  Fix for MANAGER_URL == '/'
  z-index cleanup and fix
  Fix oscillating selection in dropdown menus
  ...

Conflicts:
	core/docs/changelog.txt
	manager/assets/modext/widgets/resource/modx.panel.resource.js

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment