New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modProcessorResponse::isError() returns true on getlist processors in PHP 5.4 #9437

Closed
modxbot opened this Issue Jan 20, 2013 · 3 comments

Comments

Projects
None yet
3 participants
@modxbot

modxbot commented Jan 20, 2013

bezumkin2 created Redmine issue ID 9437

PHP 5.4 changes how empty() behaves when passed string offsets.

http://forums.modx.com/thread/81785/response--iserror-in-php-5-4-returns-true-on-getlist-processors

@modxbot

This comment has been minimized.

Show comment
Hide comment
@modxbot

modxbot commented Jan 20, 2013

romain submitted:

Related to http://tracker.modx.com/issues/9368

@goldsky

This comment has been minimized.

Show comment
Hide comment
@goldsky

goldsky Feb 12, 2013

Contributor

goldsky submitted:

I've been testing it several times, replacing

if ($response->isError()) {

with

if (!isset($response->response)) {

did the trick.

At least it's the work around for the current state.

Contributor

goldsky commented Feb 12, 2013

goldsky submitted:

I've been testing it several times, replacing

if ($response->isError()) {

with

if (!isset($response->response)) {

did the trick.

At least it's the work around for the current state.

@opengeek

This comment has been minimized.

Show comment
Hide comment
@opengeek

opengeek Mar 26, 2013

Member

opengeek submitted:

I believe a75121f will address the isError issues for now.

Member

opengeek commented Mar 26, 2013

opengeek submitted:

I believe a75121f will address the isError issues for now.

enigmatic-user pushed a commit to enigmatic-user/revolution that referenced this issue Feb 13, 2014

[modxcms#9368][modxcms#9437] Fix modProcessorResponse->isError()
Prevent returning true for getlist processors and in PHP 5.4 due to improper empty() usage

danyaPostfactum pushed a commit to danyaPostfactum/revolution that referenced this issue Mar 26, 2014

Merge branch 'release-2.2' into develop
* release-2.2:
  add changelog entry for server_offset_time fixes
  fixes to users online grid
  [modxcms#9690] fix date math to work with fractional hour offsets
  [modxcms#9690] make handling of server_offset_time consistent
  [modxcms#9690] resource xdatetime fields: server-relative in db, offset-relative in view
  [modxcms#9738] Prevent working context overriding user settings
  Fix error getting MediaSource table classes on cached Resources
  [modxcms#9368][modxcms#9437] Fix modProcessorResponse->isError()
  [modxcms#9681] add changelog entry
  2 processors $modx->runProcessor("system/country/getlist") in 1 page (cherry picked from commit dcee0eb)
  Add changelog entry
  Fixed Auto-Tag's values sorting (cherry picked from commit 926801c)

Conflicts:
	core/docs/changelog.txt
	core/model/modx/processors/system/config.js.php

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment