New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posible context wrong assign on $modx->switchContext #9524

Closed
Indomian opened this Issue Feb 18, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@Indomian

Indomian commented Feb 18, 2013

indomian created Redmine issue ID 9524

Sometimes public array $modx->contexts can be crushed with wrong key=>object data when using $modx->switchContext.
This is caused in methods $modx->getContext and $modx->_initContext. We could get situation like this:

echo $key.'=>'.$modx->contexts[$key]->get('key');

'catalog'=>'web'

This is cause because of & assignment in modx::switchContext and not filling modx::contexts caching array with propriate value.
Some way to fix uploaded here: #451

@Indomian

This comment has been minimized.

Show comment
Hide comment
@Indomian

Indomian Feb 18, 2013

indomian submitted:

Someone plz transfer this one to Revolution tracker.

Indomian commented Feb 18, 2013

indomian submitted:

Someone plz transfer this one to Revolution tracker.

@opengeek

This comment has been minimized.

Show comment
Hide comment
@opengeek

opengeek Feb 22, 2013

Member

opengeek submitted:

d74dae6

Member

opengeek commented Feb 22, 2013

opengeek submitted:

d74dae6

enigmatic-user pushed a commit to enigmatic-user/revolution that referenced this issue Feb 13, 2014

enigmatic-user pushed a commit to enigmatic-user/revolution that referenced this issue Feb 13, 2014

[modxcms#9524] Fix invalid context assignment in modX::switchContext()
Merge branch 'bug-9524' into release-2.2

* bug-9524:
  [modxcms#9524] changelog entry
  Small fix that clears errors on sites with mupltiple contexts. Sometimes array $modx->contexts get wrong key=>object assigment cause of switchContext don't fill $this->contexts array, but links it to $this->context.

danyaPostfactum pushed a commit to danyaPostfactum/revolution that referenced this issue Mar 26, 2014

Merge branch 'release-2.2' into develop
* release-2.2: (33 commits)
  Allow modX::getParser() to get an extended modParser instance
  Update core/model/modx/modx.class.php
  [modxcms#9524] changelog entry
  Small fix that clears errors on sites with mupltiple contexts. Sometimes array $modx->contexts get wrong key=>object assigment cause of switchContext don't fill $this->contexts array, but links it to $this->context.
  [modxcms#9517] changelog entry
  [modxcms#9451] changelog entry
  add changelog entry
  Increase width of file and image TVs (changelog entry)
  [modxcms#9282] changelog update
  Translated new phrases in configcheck.inc.php and setting.inc.php to German.
  Update changelog for Various UI Fixes
  [9517] - See http://tracker.modx.com/issues/9517
  [9451] - See http://tracker.modx.com/issues/9451
  [modxcms#6150] Fix issues with auto_publish when encountering invalid data
  Add title with name to thumb div
  Increase width of file and image TVs
  Give the MODx.Browser some TLC. - Increased thumb size to 100x80 - Give detail panel some more room - Fix annoying jumpiness of images
  Fix for MANAGER_URL == '/'
  z-index cleanup and fix
  Fix oscillating selection in dropdown menus
  ...

Conflicts:
	core/docs/changelog.txt
	manager/assets/modext/widgets/resource/modx.panel.resource.js

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment