New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect handling of server_offset_time causes auto publishing problems #9690

Closed
netProphET opened this Issue Mar 22, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@netProphET
Member

netProphET commented Mar 22, 2013

netprophet created Redmine issue ID 9690

In some places throughout the framework, the server_offset setting is treated as seconds, while it is intended to represent hours.
We need to ensure that

  • it is always treated and calculated as # hours
  • it can contain fraction and negative numbers
@netProphET

This comment has been minimized.

Show comment
Hide comment
@netProphET

netProphET Mar 28, 2013

Member

netprophet submitted:

For reference, the fix for this also ensured that resource timestamps are stored without the server_offset_time, and that the resource editing view adds the server_offset_time, effectively showing "localized" times to the user.

Member

netProphET commented Mar 28, 2013

netprophet submitted:

For reference, the fix for this also ensured that resource timestamps are stored without the server_offset_time, and that the resource editing view adds the server_offset_time, effectively showing "localized" times to the user.

@opengeek

This comment has been minimized.

Show comment
Hide comment
@opengeek

opengeek Mar 28, 2013

Member

opengeek submitted:

#468 for reference to the pull request

Member

opengeek commented Mar 28, 2013

opengeek submitted:

#468 for reference to the pull request

enigmatic-user pushed a commit to enigmatic-user/revolution that referenced this issue Feb 13, 2014

[modxcms#9690] resource xdatetime fields: server-relative in db, offs…
…et-relative in view

* fields still initialized with server-relative times
* apply server_offset_time to view
* apply server_offset_time when setting hidden value - the value that goes back
  to the server, so that it is relative to server time

enigmatic-user pushed a commit to enigmatic-user/revolution that referenced this issue Feb 13, 2014

[modxcms#9690] make handling of server_offset_time consistent
* remove where not needed, now that times are stored without the offset
* use same logic to convert value to seconds when it's used

enigmatic-user pushed a commit to enigmatic-user/revolution that referenced this issue Feb 13, 2014

enigmatic-user pushed a commit to enigmatic-user/revolution that referenced this issue Feb 13, 2014

[modxcms#9690] Fix various issues with server_offset_time
Merge branch 'fixtimeoffset' into release-2.2

* fixtimeoffset:
  add changelog entry for server_offset_time fixes
  fixes to users online grid
  [modxcms#9690] fix date math to work with fractional hour offsets
  [modxcms#9690] make handling of server_offset_time consistent
  [modxcms#9690] resource xdatetime fields: server-relative in db, offset-relative in view

danyaPostfactum pushed a commit to danyaPostfactum/revolution that referenced this issue Mar 26, 2014

Merge branch 'release-2.2' into develop
* release-2.2:
  add changelog entry for server_offset_time fixes
  fixes to users online grid
  [modxcms#9690] fix date math to work with fractional hour offsets
  [modxcms#9690] make handling of server_offset_time consistent
  [modxcms#9690] resource xdatetime fields: server-relative in db, offset-relative in view
  [modxcms#9738] Prevent working context overriding user settings
  Fix error getting MediaSource table classes on cached Resources
  [modxcms#9368][modxcms#9437] Fix modProcessorResponse->isError()
  [modxcms#9681] add changelog entry
  2 processors $modx->runProcessor("system/country/getlist") in 1 page (cherry picked from commit dcee0eb)
  Add changelog entry
  Fixed Auto-Tag's values sorting (cherry picked from commit 926801c)

Conflicts:
	core/docs/changelog.txt
	core/model/modx/processors/system/config.js.php

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment