New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis-CI automated test suite #12424

Merged
merged 17 commits into from Jun 23, 2015

Conversation

Projects
None yet
4 participants
@markwillis82
Collaborator

markwillis82 commented Apr 21, 2015

What does it do ?

Now that the unit test framework is working, the next step is to get unit tests built and maintained to eventually get a high %age of code tested. As a first step this PR will allow the MODX unit tests to run on travis-ci automatically.

Currently the build is Build Status on my repo branch. however to get to this status I have marked some tests as skipped.

OK, but incomplete, skipped, or risky tests!       
Tests: 543, Assertions: 592, Skipped: 15, Risky: 5.

All tests are run on: PHP 5.3, 5.4, 5.5 and 5.6. HHVM and nightlies currently fail so have excluded them from this PR so we can start on a clean/green slate.

Why is it needed ?

Until recently unit tests within MODX have been difficult to execute and even harder to write. With this PR - MODX contributors should be able to set up the tests to run on every future PR and branch. This allows better testing on-going and also should encourage the community to write additional tests to go with there Pull Requests.

Further Notes

Some of the script setup could do with some refactoring but this is a starting block to build upon.

@pixelchutes

This comment has been minimized.

Show comment
Hide comment
@pixelchutes

pixelchutes Apr 21, 2015

Collaborator

This is great, Mark!

Collaborator

pixelchutes commented Apr 21, 2015

This is great, Mark!

@OptimusCrime

This comment has been minimized.

Show comment
Hide comment
@OptimusCrime

OptimusCrime Apr 22, 2015

Contributor

This is awesome! Great work!

Contributor

OptimusCrime commented Apr 22, 2015

This is awesome! Great work!

@theboxer theboxer added this to the v2.4.0-pl milestone Jun 22, 2015

@theboxer theboxer self-assigned this Jun 22, 2015

@theboxer theboxer merged commit 4ce7a37 into modxcms:develop Jun 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment