Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Restore backwards compatibility for addons interacting with modTransportProvider #12633
What does it do?
The getClient method was previously public (see https://github.com/modxcms/revolution/blob/v2.3.6-pl/core/model/modx/transport/modtransportprovider.class.php#L73) and used by Gitify to provide a way of installing packages via the command line. When modTransportProvider was refactored, this method was marked protected, causing Gitify to break with the following error:
Fatal error: Call to protected method modTransportProvider::getClient() from context 'modmore\Gitify\Command\InstallPackageCommand' in Gitify/src/Command/InstallPackageCommand.php on line 168
Setting getClient back to public resolves that error.
Why is it needed?
2.4 was intended to be backwards compatible, however this change was overlooked. Restoring the public method will make it backwards compatible again in 2.4.1.