Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore backwards compatibility for addons interacting with modTransportProvider #12633

Merged
merged 1 commit into from Sep 21, 2015

Conversation

Projects
None yet
7 participants
@Mark-H
Copy link
Collaborator

commented Sep 4, 2015

What does it do?

The getClient method was previously public (see https://github.com/modxcms/revolution/blob/v2.3.6-pl/core/model/modx/transport/modtransportprovider.class.php#L73) and used by Gitify to provide a way of installing packages via the command line. When modTransportProvider was refactored, this method was marked protected, causing Gitify to break with the following error:

Fatal error: Call to protected method modTransportProvider::getClient() from context 'modmore\Gitify\Command\InstallPackageCommand' in Gitify/src/Command/InstallPackageCommand.php on line 168

Setting getClient back to public resolves that error.

Why is it needed?

2.4 was intended to be backwards compatible, however this change was overlooked. Restoring the public method will make it backwards compatible again in 2.4.1.

Related issue(s)/PR(s)

modmore/Gitify#125

Restore backwards compatibility for addons interacting with modTransp…
…ortProvider->getClient

The getClient method was previously public (see https://github.com/modxcms/revolution/blob/v2.3.6-pl/core/model/modx/transport/modtransportprovider.class.php#L73) and used by Gitify to provide a way of installing packages via the command line.
@Alroniks

This comment has been minimized.

Copy link
Collaborator

commented Sep 4, 2015

👍

1 similar comment
@hansek

This comment has been minimized.

Copy link
Contributor

commented Sep 8, 2015

👍

@rtripault

This comment has been minimized.

Copy link
Collaborator

commented Sep 9, 2015

The diff is somehow messy... did you change the encoding or something ?

@rtripault rtripault added this to the v2.4.1-pl milestone Sep 9, 2015

@pixelchutes

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2015

@rtripault here's the diff minus whitespace

I think the line-endings changed from Windows style [dos, CRLF] to Unix style [unix, LF] (preferred)

@Mark-H

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 11, 2015

Ah it happened again.. Phpstorm is making changes based on the .editorconfig file to make sure it follows the project standards, so like Mike said these source files must have the wrong line endings currently.

@rtripault

This comment has been minimized.

Copy link
Collaborator

commented Sep 11, 2015

Yes, you are right! I was wrongly assuming the line ending would have been correct, but it's not!
So that's rather a good thing!

Let's get this merged ? ;)

@OptimusCrime

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2015

+1!

@theboxer theboxer merged commit 578b634 into modxcms:2.4.x Sep 21, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@theboxer theboxer self-assigned this Sep 21, 2015

@Mark-H Mark-H deleted the Mark-H:issue-gitify-protectedfunc branch Feb 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.