New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #12735 missing date.timezone setting on install #12738

Merged
merged 67 commits into from Dec 10, 2015

Conversation

Projects
None yet
@Jako
Collaborator

Jako commented Oct 25, 2015

What does it do ?

Switch to a default timezone if no timezone is set in php.ini.

Why is it needed ?

A big german hosting provider (1&1) does not set this setting and it is better to have a default timezone than stopping the installation and let (maybe inexperienced) users fix that by a custom php.ini (this is the answer of the hosting providers for that issue).

Related issue(s)/PR(s)

#12735

krismas and others added some commits Aug 23, 2015

Really clear the log...
Remove the extra space when clearing « error.log » file via
`writeFile()`
Updating Font-Awesome to 4.4
66 New Icons in 4.4
we don’t need a bower version and it is ok for the package to be private
Wrong language topic
There exists no language topic 'sources' but 'source'
Wrong language topic
There exists no language topic 'sources' but 'source'
Added missing lexicon keys
Could be filled with real text and translated afterwards (has to be added to Crowdin then).
Added missing lexicon keys
The file types are used in default thumbnailType options.
Added patch for ExtJS Drag & Drop issue #12576
Added code provided by berniesaurus to fix issue where you couldn't drag and drop into a window or closable tab panel after one had already been rendered. https://www.sencha.com/forum/showthread.php?264400-Ext-JS-3.4.4.1-Drag-amp-Drop-broken
Add anonymous_sessions to allow session-less access for anonymous users
Default behavior is unchanged and set to true. When disabled however, anonymous users will not start a session when accessing a page on the site; only logged in users will have access to a session.

Also adds modX->startSession() which starts a session if not already and simply returns true if a session is available, regardless how it was started
Not rendered output properties of custom TVs
### What does it do ?
Fixing not rendered output properties of custom TVs.

### Why is it needed ?
Not rendered output properties of custom TVs.

### Related issue(s)/PR(s)
See: Jako/ImagePlus#13
inreti
Fixed emptyRecycleBin action.
In the resource tree panel, after empty Trash action the icon is still available and shows wrong description.
Fire 'emptyTrash' event on emptyRecycleBin
### What does it do ?
Fire js 'emptyTrash'  event on emptying recycle bin action like event 'OnEmptyTrash' for MODX plugins.

### Why is it needed ?
For interact with thirdparty Extra.
Prevent id of property set to be text
The id should be 0 if default properties are chosen. The value 0 properly shows "Default" text so we have no visible difference.
Fixed group settings updatins
In parent::initialize() object will getting again, but by primaryKeyField
Add slackin badge to README.md
Adds a slackin badge, as well as a link to the http://modx.org/ site for the MODX Community slack. Implements #12636.
Add slackin badge to README.md
* origin/pr/12680:
  Update Slackin badge in README.md to use HTTPS
  Add slackin badge to README.md
MAdd slackin badge to README.md
* origin/pr/12680:
  Update Slackin badge in README.md to use HTTPS
  Add slackin badge to README.md
Pass 0 as id of default property set instead of "Default"
* origin/pr/12674:
  Prevent id of property set to be text
Disable trash icon and set proper tooltip after removing resources
* origin/pr/12672:
  Fixed emptyRecycleBin action.
Fix image width and add transparency pattern
* origin/pr/12670:
  Fix image width and add transparency pattern
  Fix image width and add transparency pattern
Fix not rendering output properties of custom TVs
* origin/pr/12635:
  Not rendered output properties of custom TVs
Merge remote-tracking branch 'origin/pr/12602' into 2.4.x
* origin/pr/12602:
  Added missing lexicon keys
  Added missing lexicon keys
  Wrong language topic
  Wrong language topic
Add hover effect to tree expand/collapse icon
* origin/pr/12664:
  Update _tree.scss

theboxer and others added some commits Oct 6, 2015

Fix emptying property sets on element save
* property-sets:
  Updates for the modPropertySetUpdateFromElementProcessor processor
  Bugfix for #12580
Update lexicons from crowdin
Crowdin project: http://translate.modx.com
Thanks to all translators and proofreaders for contribution!
Bugfix for failure message
$f was removed in 9a46c45
Fix tree style for deactivated plugin
* origin/pr/12712:
  Fixed #12710 tree style for deactivated plugins.
Fix failure message in Export processor
* origin/pr/12709:
  Better variable names
  Missing semicolon
  Bugfix for failure message
Fix dashboard and dashboard widget save button
* origin/pr/12711:
  Corrected dashboard's save button action
Fix loading rich text editors on non-document resource types
* origin/pr/12632:
  Fix loading rich text editors on non-document resource types
Add examples to TV option "Where Condition" to simplify usage.
* origin/pr/12702:
  Added examples to TV option "Where Condition" to simplify usage.
Add anonymous_sessions to allow session-less access for anonymous users
* origin/pr/12616:
  Add anonymous_sessions to allow session-less access for anonymous users
Fire emptyTrash event after emptying recycle bin
* origin/pr/12673:
  Fire  'emptyTrash'  event on emptyRecycleBin
Allow custom redirect method for each action button in action bar
* origin/pr/12703:
  Add option to allow define custom redirect method for each action button
@Jako

This comment has been minimized.

Collaborator

Jako commented on 65ff65e Oct 28, 2015

The error messages have to be retranslared on crowdin.

@rtripault

This comment has been minimized.

Collaborator

rtripault commented Nov 26, 2015

Makes sense, and looks good to me, 👍

@Mark-H Mark-H added this to the v2.5.0-pl milestone Dec 10, 2015

@Mark-H Mark-H self-assigned this Dec 10, 2015

@Mark-H Mark-H merged commit 350e1f9 into modxcms:2.x Dec 10, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Mark-H

This comment has been minimized.

Collaborator

Mark-H commented Dec 10, 2015

Thanks @Jako for another useful contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment