New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to make use of the maximum available height for logs textarea #12746

Merged
merged 1 commit into from Dec 1, 2015

Conversation

Projects
None yet
3 participants
@rtripault
Collaborator

rtripault commented Oct 31, 2015

What does it do ?

Sets the error log textarea height (the one holding the log content) to the maximum available client viewport height

Why is it needed ?

The current "growth" is set to 400px height max. Meaning it leaves a lot of unused "white space" below the textarea, which could be used to display more log data.

Steps to reproduce issue

  • On a screen with more than 600px height, just head to the error log and see the textarea is not "maximized"

Related issue(s)/PR(s)

@rtripault rtripault closed this Oct 31, 2015

@rtripault rtripault reopened this Oct 31, 2015

@jpdevries

This comment has been minimized.

Contributor

jpdevries commented Nov 29, 2015

would be great to make full use of available space for editing elements and resource content also.

@Mark-H Mark-H self-assigned this Dec 1, 2015

@Mark-H Mark-H added this to the v2.5.0-pl milestone Dec 1, 2015

@Mark-H Mark-H merged commit 14abdcd into modxcms:2.x Dec 1, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Mark-H

This comment has been minimized.

Collaborator

Mark-H commented Dec 1, 2015

Very cool, nicely done @rtripault! :)

@rtripault rtripault deleted the rtripault:system-log-textarea-size branch Dec 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment