New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning "user not found." for the page title if user does not exist #12772

Closed
wants to merge 3 commits into
base: develop
from

Conversation

Projects
None yet
2 participants
@tehsquidge
Contributor

tehsquidge commented Nov 21, 2015

What does it do ?

Returning "user not found." for the page title if user does not exist when trying to edit.

Why is it needed ?

Currently it will try and return a page title which references the user object, which will be null if the user does not exist. This creates a "PHP Fatal error" and a 500 error. With this fix the "user not found." message can actually appear.

tehsquidge and others added some commits Mar 31, 2014

500 error editing user which doesn't exist
Fixing PHP Fatal error when trying to edit a user which doesn't exist. The page title references the user, which doesn't exist.

@Mark-H Mark-H added this to the v2.4.3-pl milestone Nov 22, 2015

@Mark-H

This comment has been minimized.

Collaborator

Mark-H commented Nov 22, 2015

Hi @tehsquidge, thanks for your contribution!

This pull request should have been based off the 2.4.x branch and also targeting that branch rather than develop, but I think we'll manage to merge it. You can find out more about the branching strategy we're using, please have a look at https://github.com/modxcms/revolution/blob/2.x/CONTRIBUTING.md#choosing-the-correct-branch :)

@Mark-H

This comment has been minimized.

Collaborator

Mark-H commented Dec 3, 2015

Merged into 2.4.3 in 41858b2, thanks again!

@Mark-H Mark-H self-assigned this Dec 3, 2015

@Mark-H Mark-H closed this Dec 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment