New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating font-awesome to ^4.5.0 #12774

Merged
merged 1 commit into from Dec 1, 2015

Conversation

Projects
None yet
4 participants
@jpdevries
Contributor

jpdevries commented Nov 21, 2015

What does it do ?

Updates font-awesome to ^4.5.0

Why is it needed ?

Adds the MODX logo the font awesome set 馃憤

Related issue(s)/PR(s)

#12770

Closes #12770 because this will fetch any version of 4.4.x when running bower update

@jpdevries jpdevries force-pushed the jpdevries:font-awesome-4.4.0 branch from cd6eaee to 19eef7a Nov 23, 2015

@jpdevries

This comment has been minimized.

Contributor

jpdevries commented Nov 23, 2015

font awesome 4.5 just dropped. even though this branch is named 4.4, it updates it to 4.5 and INCLUDES THE MODX LOGO!!! 馃帀

@jpdevries jpdevries changed the title from Updating font-awesome to ^4.4.0 to Updating font-awesome to ^4.5.0 Nov 23, 2015

@pixelchutes

This comment has been minimized.

Collaborator

pixelchutes commented Nov 24, 2015

Sweet!! 馃嵒

I think we should only need the bower.json in the PR, see e2a7e87

@rtripault rtripault added this to the v2.5.0-pl milestone Nov 26, 2015

@jpdevries

This comment has been minimized.

Contributor

jpdevries commented Nov 27, 2015

I ran grunt build to update the fonts themselves in the commit but I can update the commit to just include bower.json if needed.

@jpdevries jpdevries force-pushed the jpdevries:font-awesome-4.4.0 branch from 19eef7a to 96516d4 Nov 28, 2015

@jpdevries

This comment has been minimized.

Contributor

jpdevries commented Nov 28, 2015

updated the branch, now only includes bower.json so make sure to bower update && grunt build when merging.

@Mark-H

This comment has been minimized.

Collaborator

Mark-H commented Dec 1, 2015

鉂わ笍 icon-modx

@Mark-H Mark-H self-assigned this Dec 1, 2015

@Mark-H Mark-H merged commit 96516d4 into modxcms:2.x Dec 1, 2015

@jpdevries jpdevries deleted the jpdevries:font-awesome-4.4.0 branch Dec 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment