New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling on non-mobile displays #12799

Merged
merged 1 commit into from Dec 5, 2015

Conversation

Projects
None yet
2 participants
@Mark-H
Collaborator

Mark-H commented Dec 3, 2015

What does it do?

Limit the width/height: auto to small displays only.

Why is it needed?

These lines cause it to be impossible to scroll on larger displays. By limiting the css to mobile media, scrolling is brought back to the manager on larger displays.

Related issue(s)/PR(s)

#12776 and in particular @rtripault's comments here: b9d4e74#commitcomment-14759403

Fix scrolling on non-mobile displays
This bug was introduced in b9d4e74 and caused scrolling the page to be broken on large displays (whoops). Limiting the auto width/height to mobile screens fixes that.

@Mark-H Mark-H added this to the v2.5.0-pl milestone Dec 3, 2015

@rtripault rtripault self-assigned this Dec 5, 2015

@rtripault rtripault merged commit b44b639 into modxcms:2.x Dec 5, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Mark-H Mark-H deleted the Mark-H:bug-12776-fixscroll branch Feb 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment