New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update login.class.php #12802

Closed
wants to merge 1 commit into
base: 2.x
from

Conversation

Projects
None yet
3 participants
@timbx

timbx commented Dec 5, 2015

What does it do ?

Fix a tiny mistake in Login processor, which is not allows users to save session for "session_cookie_lifetime" value.

Why is it needed ?

Fix the problem with session saving when remember me value is not "on" (manager login form passed a value of remember me "1").

Related issue(s)/PR(s)

Issue #12754

Update login.class.php
fix the rememberme unsaved problem
@pixelchutes

This comment has been minimized.

Collaborator

pixelchutes commented Dec 5, 2015

Fix for #12754

@Mark-H

This comment has been minimized.

Collaborator

Mark-H commented Dec 5, 2015

Could you please use the template from the contributing docs in the contributing.md file for your pull request description?

Also can you let me know your MODX.com username and if you've signed our CLA? That's needed in order to accept your pull request into the core.

@Mark-H

This comment has been minimized.

Collaborator

Mark-H commented Dec 7, 2015

Hi @timbx - did you see my comment over the weekend? Would love to get this merged, but we do need a CLA on file.

@Mark-H Mark-H added this to the v2.4.3-pl milestone Dec 8, 2015

@timbx

This comment has been minimized.

timbx commented Dec 8, 2015

Hello @Mark-H,
Thank you for your comment, I am newbie. My username on modx.com timbx999, and I signed the CLA.

@Mark-H

This comment has been minimized.

Collaborator

Mark-H commented Dec 8, 2015

Thanks @timbx :)

@Mark-H

This comment has been minimized.

Collaborator

Mark-H commented Dec 8, 2015

Thank you @timbx, this has been cherry picked into the 2.4.x branch for inclusion in 2.4.3 in c188eb7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment