New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix travis builds on PHP 5.5 #12804

Merged
merged 1 commit into from Dec 6, 2015

Conversation

Projects
None yet
2 participants
@Mark-H
Collaborator

Mark-H commented Dec 5, 2015

What does it do ?

Based on fix in http://andreas.heigl.org/2015/11/12/testing-code-with-phpunit-on-travis-ci-for-php-5-5-and-php7/ and the discussion in travis-ci/travis-ci#5206 (comment), this adjustment makes sure that on PHP 5.5, phpunit 4.x is loaded rather than 5.x which is not compatible with PHP 5.5, but required for PHP7.

Why is it needed ?

The travis build indicates it fails on PHP 5.5 due to an unsupported version of phpunit.

Related issue(s)/PR(s)

Brief discussion here: #12803 (comment)

@Mark-H

This comment has been minimized.

Collaborator

Mark-H commented Dec 5, 2015

@Mark-H

This comment has been minimized.

Collaborator

Mark-H commented Dec 5, 2015

🎉

Fix travis builds on PHP 5.5
Based on fix in http://andreas.heigl.org/2015/11/12/testing-code-with-phpunit-on-travis-ci-for-php-5-5-and-php7/ and travis-ci/travis-ci#5206, this adjustment makes sure that on PHP 5.5, phpunit 4.x is loaded rather than 5.x which is not compatible with PHP 5.5, but required for PHP7.

@Mark-H Mark-H force-pushed the Mark-H:fix-travis-build-on-php55 branch from 806b45b to d986b01 Dec 5, 2015

@Mark-H

This comment has been minimized.

Collaborator

Mark-H commented Dec 5, 2015

Took some tweaking, but this is finally green again on PHP 5.5. I've squashed all commits to make it a bit cleaner.

pixelchutes added a commit that referenced this pull request Dec 6, 2015

@pixelchutes pixelchutes merged commit 89f4532 into modxcms:2.x Dec 6, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

pixelchutes added a commit to pixelchutes/revolution that referenced this pull request Dec 8, 2015

Merge pull request modxcms#12804 from Mark-H/fix-travis-build-on-php55
Fix travis builds on PHP 5.5
(cherry picked from commit 89f4532)

Conflicts:
	.travis.yml

@Mark-H Mark-H deleted the Mark-H:fix-travis-build-on-php55 branch Feb 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment