New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make modphpthumb.class.php compatible with PHP 7 #12809

Merged
merged 3 commits into from Dec 10, 2015

Conversation

Projects
None yet
2 participants
@exside
Contributor

exside commented Dec 7, 2015

What does it do ?

Replaces removed functions ereg() and eregi() with preg_replace() equivalents (hopefully, somebody with more PHP skills please verify this =D).

Why is it needed ?

To make MODX PHP 7 compatible, the media browser is broken without this...

Related issue(s)/PR(s)

#12797, #12810

@Mark-H

This comment has been minimized.

Collaborator

Mark-H commented Dec 8, 2015

Hey @exside - could you perhaps elaborate how (if at all) this ties in with the phpthumb update in #12810?

@exside

This comment has been minimized.

Contributor

exside commented Dec 8, 2015

@Mark-H It doesn't codewise but they are related in the sense that modphpthumb controls phpthumb and both need updates to work properly with PHP 7 =)...hope that makes sense?

@exside exside referenced this pull request Dec 9, 2015

Closed

HHVM errors #12821

@Mark-H Mark-H merged commit 19c2570 into modxcms:2.x Dec 10, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Mark-H

This comment has been minimized.

Collaborator

Mark-H commented Dec 10, 2015

Mucho gracias!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment