New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect view_url after changing the resource alias #13740 #13768

Merged
merged 1 commit into from Feb 9, 2018

Conversation

Projects
None yet
3 participants
@jdaehne
Contributor

jdaehne commented Feb 9, 2018

What does it do?

makeUrl() was loading the cached aliasMap. It reloads the Content after saving the resource to receive the updated aliasMap with the new set alias.

Why is it needed?

After changing the alias and saving the resource, the "publish button" showed/opened the old URL (preview_url).

Related issue(s)/PR(s)

#13740

@superspace

This comment has been minimized.

superspace commented Feb 9, 2018

I tested several combinations of published/unpublished resources, duplicating, editing etc. and the "View"-button always opended the correct URL.
#modxbughunt

@Mark-H Mark-H changed the title from resolve #13740 to Fix incorrect view_url after changing the resource alias #13740 Feb 9, 2018

@Mark-H

This comment has been minimized.

Collaborator

Mark-H commented Feb 9, 2018

@jdaehne Please use a better title next time ;)

@Mark-H Mark-H added this to the v2.6.2 milestone Feb 9, 2018

@Mark-H Mark-H self-assigned this Feb 9, 2018

@Mark-H Mark-H merged commit a18f53c into modxcms:2.6.x Feb 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Mark-H

This comment has been minimized.

Collaborator

Mark-H commented Feb 9, 2018

I'm happy this is finally fixed - thanks @jdaehne!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment