New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent adding ./ to filepath when in root of a mediasource [12625] #13778

Merged
merged 1 commit into from Mar 26, 2018

Conversation

Projects
None yet
4 participants
@Bruno17
Contributor

Bruno17 commented Feb 14, 2018

What does it do?

Only returns the dirname in getOpenTo, when not in root, otherwise returns an empty string

Why is it needed?

Solves the issue with prefixed ./ in image or file - TVs, when in Root.
Doesn't happen the first time, but as soon as the Manager - Page is reloaded and a image or file-TV is saved again. Then the openTo was ./ and this was prefixed to the filepath

Related issue(s)/PR(s)

Related to
#12625
and
#11830

@Jako Jako added this to the v2.6.2 milestone Feb 15, 2018

@opengeek opengeek requested review from bezumkin and Mark-H Mar 26, 2018

@bezumkin

Yes, it is already was fixed in new media sources for 3.x branch

@opengeek opengeek merged commit 2469d7d into modxcms:2.6.x Mar 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@opengeek opengeek removed the request for review from Mark-H Mar 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment