New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix headers being overwritten in modRest (#12500) #13797

Merged
merged 2 commits into from Mar 26, 2018

Conversation

Projects
None yet
3 participants
@JoshuaLuckers
Contributor

JoshuaLuckers commented Feb 28, 2018

What does it do?

Prevents the existing headers from being overwritten when preparing the headers.

Related issue(s)/PR(s)

Bug #12500

@Mark-H

This comment has been minimized.

Collaborator

Mark-H commented Mar 2, 2018

Hey @JoshuaLuckers, thanks for sending in this contribution. Looks like it's your first, so welcome! :) If you haven't yet, could you please submit the CLA via https://develop.modx.com/contribute/cla/?

Any chance you could share some steps to reproduce the bug to help verify the fix?

Also code-style wise, please put the body of if statements on their own lines wrapped by curly braces.

@Mark-H Mark-H changed the title from Fix in modRest for bug #12500 to Fix headers being overwritten in modRest (#12500) Mar 2, 2018

@Mark-H Mark-H added this to the v2.6.2 milestone Mar 2, 2018

@JoshuaLuckers

This comment has been minimized.

Contributor

JoshuaLuckers commented Mar 2, 2018

Hey @JoshuaLuckers, thanks for sending in this contribution. Looks like it's your first, so welcome! :) If you haven't yet, could you please submit the CLA via https://develop.modx.com/contribute/cla/?

It's indeed my first pull-request @Mark-H. I already submitted the CLA.

Any chance you could share some steps to reproduce the bug to help verify the fix?

I will create a sample to reproduce the issue later.

Also code-style wise, please put the body of if statements on their own lines wrapped by curly braces.
Sure, will do it later today. Normally I do put them around curly braces, but I wanted to keep it consistent with the style used in the file.

@JoshuaLuckers

This comment has been minimized.

Contributor

JoshuaLuckers commented Mar 2, 2018

@Mark-H I posted the code to reproduce the error in the original bug report.

@gpsietzema gpsietzema added this to Testing in MODX3 Mar 20, 2018

@opengeek opengeek merged commit 8fa9b7d into modxcms:2.6.x Mar 26, 2018

@gpsietzema gpsietzema removed this from Testing in MODX3 Apr 9, 2018

@JoshuaLuckers JoshuaLuckers deleted the JoshuaLuckers:bug-12500 branch Aug 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment