Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Only save properties modified from the default for an element #13799
In the Property Set UI, a "bug fix" incorporated in 2.4.2 broke property sets causing them to save all properties from an element to the set, instead of only those modified from the Default property values for an element. This should restore that behavior but still prevent the reported bug which lead to this change.
What does it do?
Reverted the changes which prevented comparing default properties to the values being sent to the processor.
Why is it needed?
Restoring intended behavior to property sets (i.e. saving only properties to the set with values modified from the default specified for the element they originated from).
Rather than blankly reverting a bugfix, any chance there's a way to fix the issue you're seeing without also reintroducing the previous issue? In slack you mentioned something about it being hard to fix in both the property sets panels and the elements' properties tab, but if this were to get merged, someone else might want to reintroduce the other fix to address that issue again...