New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only save properties modified from the default for an element #13799

Merged
merged 1 commit into from Mar 29, 2018

Conversation

Projects
3 participants
@opengeek
Member

opengeek commented Mar 1, 2018

In the Property Set UI, a "bug fix" incorporated in 2.4.2 broke property sets causing them to save all properties from an element to the set, instead of only those modified from the Default property values for an element. This should restore that behavior but still prevent the reported bug which lead to this change.

This reverts commit bd61e77 introduced via PR #12614 intended to address a bug reported in #12580.

What does it do?

Reverted the changes which prevented comparing default properties to the values being sent to the processor.

Why is it needed?

Restoring intended behavior to property sets (i.e. saving only properties to the set with values modified from the default specified for the element they originated from).

Related issue(s)/PR(s)

#12580
#12614
#12695

@Mark-H

This comment has been minimized.

Collaborator

Mark-H commented Mar 2, 2018

Rather than blankly reverting a bugfix, any chance there's a way to fix the issue you're seeing without also reintroducing the previous issue? In slack you mentioned something about it being hard to fix in both the property sets panels and the elements' properties tab, but if this were to get merged, someone else might want to reintroduce the other fix to address that issue again...

@opengeek

This comment has been minimized.

Member

opengeek commented Mar 2, 2018

This was not blankly reverting anything. I can't reproduce the original issue at all. Feel free to test since no one did originally, obviously.

@gpsietzema gpsietzema added this to Testing in MODX3 Mar 20, 2018

@opengeek opengeek modified the milestones: v2.7.0, v2.6.2 Mar 26, 2018

@opengeek opengeek requested review from theboxer and Mark-H Mar 27, 2018

Restore behavior in Property Set UI that only saves properties modifi…
…ed from the default for an element

Revert "Bugfix for #12580"

This reverts commit bd61e77 introduced via PR #12614.

@opengeek opengeek changed the base branch from 2.x to 2.6.x Mar 27, 2018

@opengeek opengeek merged commit 80f0b37 into modxcms:2.6.x Mar 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gpsietzema gpsietzema moved this from Testing to Done in MODX3 Apr 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment