New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] [ReUp] Sidebar Improvements #13996

Merged
merged 2 commits into from Jul 27, 2018

Conversation

Projects
None yet
3 participants
@jonleverrier
Contributor

jonleverrier commented Jul 16, 2018

What does it do?

Added a default CSS height to #modx-header to make the sidebar feel less jumpy on page load whilst the javascript loads. It gives the impression the manager is loading faster than it actually is (#13953)

42212742-4ad8a274-7eb7-11e8-9cfa-41f4374d7d39

Tweaked the sidebar styles so if a menu title falls onto 2 lines or more it doesn't look broken (#13983)

42446168-9ab22244-8375-11e8-8d12-14ca6daa1d94

Why is it needed?

Better User Experience.

Related issue(s)/PR(s)

Fixes #13953
Fixes #13983

@jonleverrier jonleverrier requested review from Mark-H and opengeek as code owners Jul 16, 2018

@Mark-H

Mark-H approved these changes Jul 16, 2018

@jonleverrier jonleverrier changed the title from [3.x] [ReUp] Sidebar Imrprovements to [3.x] [ReUp] Sidebar Improvements Jul 16, 2018

@Alroniks Alroniks added this to the v3.0.0-alpha milestone Jul 17, 2018

@Alroniks Alroniks merged commit 7bb765b into modxcms:3.x Jul 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Alroniks added a commit that referenced this pull request Jul 27, 2018

Sidebar styles glitches improvements #13996
* upstream/pr/13996:
  tweaked sidebar styles to allow menu titles to fall onto multiple lines
  improved performance of sidebar whilst loading

@jonleverrier jonleverrier deleted the jonleverrier:sidebarimprovements branch Jul 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment