New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the flat file processor deprecated message more useful #14160

Merged
merged 1 commit into from Dec 5, 2018

Conversation

@Mark-H
Collaborator

Mark-H commented Nov 28, 2018

What does it do?

The new deprecated messages introduced in #14136 are being triggered now that 2.7 is out, but the one for flat file processors is missing some context. This PR changes that message a bit, to include the calling action and the path.

Why is it needed?

Previous message lacked the information needed to identify the problem:

[2018-11-28 21:50:14] (ERROR in modProcessor::run @ /home/user/public_html/core/model/modx/modprocessor.class.php : 177) Flat file processor support is deprecated since version 2.7.0.

Now, it's more helpful:

[2018-11-28 21:59:26] (ERROR in modProcessor::run @ /home/user/public_html/core/model/modx/modprocessor.class.php : 177) Flat file processor support, used for action system/event with path /home/user/public_html/core/model/modx/processors/system/config.js.php, is deprecated since version 2.7.0.

Related issue(s)/PR(s)

#14136, #14127

@Mark-H Mark-H requested a review from opengeek as a code owner Nov 28, 2018

@Mark-H Mark-H modified the milestones: v2.7.0, v2.7.1 Nov 28, 2018

@Alroniks Alroniks self-assigned this Dec 3, 2018

Alroniks added a commit to Alroniks/revolution that referenced this pull request Dec 5, 2018

Make the flat file processor deprecated message more useful [modxcms#…
…14160]

* upstream/pr/14160:
  Make the flat file processor deprecated message more useful for pinpointing the source

@Alroniks Alroniks merged commit 2b3f8e5 into modxcms:2.x Dec 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment