Repository navigation
Update config.js.php processor to be class based - #14161
Merged
Merged
Conversation
…s.php in a setup migration
JoshuaLuckers
suggested changes
Nov 28, 2018
Jako
approved these changes
Nov 29, 2018
opengeek
approved these changes
Dec 3, 2018
alroniks
pushed a commit
that referenced
this pull request
Dec 5, 2018
* upstream/pr/14161: Back to the future! (Fix referred version) Update config.js processor to be class based, and remove old config.js.php in a setup migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
In #14160 I made the deprecated message a bit more useful for identifying offending processors, which immediately pointed to the config.js.php which is called on each manager request as loading the config into a JS object. So, I wrapped it into a modProcessor class to resolve that, and added a migration to remove the old processor file when running the 2.7.1 setup.
Why is it needed?
The deprecated log message on each manager request will not only get annoying fast, but as it's not very useful until #14160, this particular instance may encourage people to disable the deprecated logging preventing them from seeing other deprecated usages that need to be fixed.
Related issue(s)/PR(s)
#14160