New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction on the consistency of design and buttons #14306

Merged
merged 2 commits into from Jan 29, 2019

Conversation

@Ibochkarev
Copy link
Contributor

Ibochkarev commented Jan 23, 2019

What does it do?

Improves the consistency of the design, and the color of the buttons and their state when you hover the mouse

Why is it needed?

Fixed:

  • button color, hover colors
  • removed unnecessary styles after replacing colors
  • replaced red, yellow, darkGray and orange colors with clearer and more suitable
  • changed styles of borders of panels and tabs

Before fix:
2019-01-23_21-39-56

After fix:
2019-01-23_21-24-04

After

Related issue(s)/PR(s)

Issue #13958

@Ibochkarev Ibochkarev requested review from Mark-H and opengeek as code owners Jan 23, 2019

@Mark-H

Mark-H approved these changes Jan 24, 2019

@Ruslan-Aleev
Copy link
Contributor

Ruslan-Aleev left a comment

Tested, everything works well.

new_buttons

@Ibochkarev

This comment has been minimized.

Copy link
Contributor Author

Ibochkarev commented Jan 29, 2019

@JoshuaLuckers Hi! Please check this PR.

@JoshuaLuckers JoshuaLuckers self-requested a review Jan 29, 2019

@Jako

Jako approved these changes Jan 29, 2019

@Alroniks Alroniks self-assigned this Jan 29, 2019

@Alroniks Alroniks changed the title Correction on the consistency of design and buttons #13958 Correction on the consistency of design and buttons Jan 29, 2019

@Alroniks Alroniks merged commit 86a4b9b into modxcms:3.x Jan 29, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Alroniks added a commit that referenced this pull request Jan 29, 2019

Correction on the consistency of design and buttons #14306
* upstream/pr/14306:
  Change modx-tree-node-btn-create, add transition for buttons
  Correction on the consistency of design and buttons

@Ibochkarev Ibochkarev deleted the Ibochkarev:13958-correction-design branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment