Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Minor authorization page fixes styles #14310
What does it do?
With this PR, I adjust the styles a little 3.x. This PR is focused on changing the visual representation of the authorization page.
I have corrected:
Why do you need it?
Redesign is one of the key features of MODX3 and I tried to bring the styles of this page a little closer to the overall design.
I like the success/error styles! However the logo looks way too big for me now. I'm also not sure about the inputs as they look somehow disabled now?
Is the (button) green the same as the current primary color of the manager interface? Because at the time when we were working on the login, the previous color was used as primary in the manager.
@christianseel I ask you to test these changes. Since there is always the possibility to make adjustments.
I will fix the logo.
Thanks for the feedback. I tried to do in the same style.
Alroniks left a comment
After the quick look:
I agree with @Alroniks on the focus status (the inset box shadow is a little too subtle), and I'd probably take out the letter-spacing on the ghost buttons/password reset link. Makes it look a little stretched and inconsistent with other text on latin text:
Those two things changed would earn my
I don't really have an opinion on the blue color. I think it's an interesting shade of blue, but if it's not used anywhere else but the login page, it may make sense to restore that to something more consistent.
@JoshuaLuckers: Design is very subjective of course, but in my opinion the screenshots made it clear that it adds more polish to the design, which is more than enough argumentation in my book ;)