Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change System font stack #14415

Merged
merged 1 commit into from Mar 6, 2019

Conversation

@Ibochkarev
Copy link
Contributor

commented Feb 21, 2019

What does it do?

Change System font stack.
Defaulting to the system font of a particular operating system can boost performance because the browser doesn't have to download any font files, it's using one it already had. That's true of any "web safe" font, though. The beauty of "system" fonts is that it matches what the current OS uses, so it can be a comfortable look.

Why is it needed?

Change the current base font set to suggested:
font-family: -apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,Oxygen-Sans,Ubuntu,Cantarell,"Helvetica Neue",sans-serif;

This set of fonts is used:

Before:
2019-02-21_11-09-25

After:
2019-02-21_11-11-39

Before:
2019-02-21_11-00-18

After:
2019-02-21_11-06-13

Before:
2019-02-21_10-58-52

After:
2019-02-21_11-06-35

Before:
2019-02-21_10-59-35

After:
2019-02-21_11-24-20

More information here:

Environment:

  • MODX 3.x
  • MacOS 10.13.6 (17G5019)
  • Google Chrome: 72.0.3626.109

Related issue(s)/PR(s)

NA

@petyagrill

This comment has been minimized.

Copy link

commented Feb 21, 2019

It looks very nice

Before:
_ modx revolution
_ home _ modx revolution

After:
_ home _ modx revolution 2
_ home _ modx revolution 3

Environment:

  • MODX 3.x
  • Ubuntu 18.04.2 LTS
  • Google Chrome: 72.0.3626.96

@Jako Jako added this to the v3.0.0-alpha milestone Feb 21, 2019

@Jako Jako added the enhancement label Feb 21, 2019

@Ibochkarev Ibochkarev marked this pull request as ready for review Feb 21, 2019

@Ibochkarev Ibochkarev requested review from Mark-H and opengeek as code owners Feb 21, 2019

@Ibochkarev

This comment has been minimized.

Copy link
Contributor Author

commented Mar 1, 2019

@Mark-H Please check this PR

@Mark-H

Mark-H approved these changes Mar 5, 2019

Copy link
Collaborator

left a comment

I will review PRs even if you don't mention me @Ibochkarev ;) Just a little busy with other things so it may take me a little longer every now and then.

@JoshuaLuckers JoshuaLuckers self-assigned this Mar 6, 2019

@JoshuaLuckers JoshuaLuckers merged commit 3762472 into modxcms:3.x Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.