Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MODX 3 require at least PHP 7.0 #14488

Merged
merged 1 commit into from Apr 28, 2019

Conversation

@JoshuaLuckers
Copy link
Collaborator

commented Mar 15, 2019

What does it do?

Update the minimum required PHP version to PHP 7.0

Why is it needed?

This allows use to modernise the codebase and drop support for legact version of PHP.

@JoshuaLuckers JoshuaLuckers added this to the v3.0.0-alpha milestone Mar 15, 2019

@JoshuaLuckers JoshuaLuckers requested review from Mark-H and opengeek as code owners Mar 15, 2019

@JoshuaLuckers JoshuaLuckers force-pushed the JoshuaLuckers:no-legacy-php-support branch from a613985 to 2669012 Mar 15, 2019

@JoshuaLuckers JoshuaLuckers changed the title Make MODX 3 require at least PHP 7.1 Make MODX 3 require at least PHP 7.0 Mar 15, 2019

@Mark-H
Copy link
Collaborator

left a comment

+6 -8 with a massive impact :)

@JoshuaLuckers JoshuaLuckers dismissed stale reviews from Mark-H and opengeek via a613985 Mar 15, 2019

@JoshuaLuckers JoshuaLuckers force-pushed the JoshuaLuckers:no-legacy-php-support branch from 2669012 to a613985 Mar 15, 2019

@JoshuaLuckers JoshuaLuckers force-pushed the JoshuaLuckers:no-legacy-php-support branch from a613985 to 660aa36 Mar 15, 2019

@digitalpenguin

This comment has been minimized.

Copy link

commented Mar 16, 2019

Yes please, at least 7.1

@JoshuaLuckers

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 17, 2019

There is a user base we had to consider bumping the minimum required PHP-version and if needed we can always increase the minimum required PHP version in a minor release of MODX 3. 😄

@Mark-H

Mark-H approved these changes Mar 25, 2019

@JoshuaLuckers JoshuaLuckers self-assigned this Apr 27, 2019

@JoshuaLuckers JoshuaLuckers merged commit 660aa36 into modxcms:3.x Apr 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@JoshuaLuckers JoshuaLuckers deleted the JoshuaLuckers:no-legacy-php-support branch Apr 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.