Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New design for installer #14507

Open
wants to merge 43 commits into
base: 3.x
from

Conversation

Projects
None yet
8 participants
@Ibochkarev
Copy link
Contributor

commented Mar 24, 2019

What does it do?

Describe the technical changes you did.

  • Add rules to gruntfile.js for compiling styles for the installer
  • Connect normalize to reset styles
  • Delete unused images
  • Delete unnecessary style files after assembly via Grunt
  • Rewrite layout using flexbox
  • Change the order of fields to fill

Why is it needed?

It is rewritten the pages of the installer in accordance with the designed design.

Screenshots

1-1
1-2
2
3
4
5
6
7
8

Related issue(s)/PR(s)

#14504 #14238

@Jako Jako added this to the v3.0.0-alpha milestone Apr 1, 2019

@OptimusCrime

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

Want to share some print screens of how this looks?

@jonleverrier

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

I think the designs are from the related issue @OptimusCrime #14504

@Ibochkarev

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

@jonleverrier Yes. That's right.

@Ibochkarev Ibochkarev force-pushed the Ibochkarev:Installer branch from 48580be to 7b739b0 Apr 7, 2019

@JoshuaLuckers
Copy link
Collaborator

left a comment

Please don't commit the compiled CSS. The integrator who merges the PR will compile the final CSS.

@Ibochkarev

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

Please don't commit the compiled CSS. The integrator who merges the PR will compile the final CSS.

@JoshuaLuckers ok! I fixed this

Ibochkarev added some commits Apr 16, 2019

@Ibochkarev Ibochkarev marked this pull request as ready for review May 9, 2019

@Ibochkarev Ibochkarev requested review from Mark-H and opengeek as code owners May 9, 2019

@Ibochkarev

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

Please test.

@Ibochkarev Ibochkarev force-pushed the Ibochkarev:Installer branch from 148b61f to 0b6f66d May 14, 2019

@opengeek

This comment has been minimized.

Copy link
Member

commented May 15, 2019

Please, stop merging 3.x back into your PR branches. Can you remove that? If you need to update the PR, rebase it on top of the latest 3.x instead.

@Ibochkarev Ibochkarev force-pushed the Ibochkarev:Installer branch from 3c831ff to f681686 May 15, 2019

Ibochkarev and others added some commits May 16, 2019

Merge pull request #3 from webinmd/Installer
Added style for current step
@Alroniks

This comment has been minimized.

Copy link
Collaborator

commented May 21, 2019

It seems pretty ready for testing and merging after. Please, have a look.

@Alroniks
Copy link
Collaborator

left a comment

Despite the fact that I also made edits, for me, everything looks good. Very obvious errors are corrected, the remaining trifles should be corrected after the merge.

@JoshuaLuckers

This comment has been minimized.

Copy link
Collaborator

commented May 22, 2019

I'll test it this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.