Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added date and time to the list of recently edited resources in the personal profile #14540

Open
wants to merge 3 commits into
base: 3.x
from

Conversation

Projects
None yet
4 participants
@igorsuhinin
Copy link

commented Apr 8, 2019

What does it do?

Adds date and time to the list of recently edited resources in the personal profile.

Why is it needed?

Currently the list of recently edited resources doesn't show the date & time when the resource was edited. There is also a small bug: the list of YOUR recently edited resources in the personal profile shows the most recently edited resources without filtering by the current user ID.

Related issue(s)/PR(s)

Issue #11264
PR #14511

Igor Sukhinin added some commits Apr 5, 2019

@igorsuhinin igorsuhinin requested review from Mark-H and opengeek as code owners Apr 8, 2019

$q = $this->modx->newQuery($this->classKey, ['classKey:IN' => $this->classKeys]);
$q->select('MAX(id), item');
if (!empty($user)) {
$q->where(['user' => $user]);
$c->where(['user' => $user]);

This comment has been minimized.

Copy link
@Alroniks

Alroniks Apr 8, 2019

Collaborator

Is it required here?

This comment has been minimized.

Copy link
@Alroniks

Alroniks Apr 8, 2019

Collaborator

Seems like accidentally duplicated lines. Need to leave the first one.

This comment has been minimized.

Copy link
@igorsuhinin

igorsuhinin Apr 8, 2019

Author

Seems like accidentally duplicated lines. Need to leave the first one

Not really, both are required. Please note, there are two different variables $q and $c.

I just tried to make as less changes as I could. So I just used the variables which were added before.

This comment has been minimized.

Copy link
@Alroniks

Alroniks Apr 8, 2019

Collaborator

Ok, I see now. 👍

@Mark-H

Mark-H approved these changes Apr 25, 2019

@Mark-H Mark-H added this to the v3.0.0-alpha milestone Apr 25, 2019

@Mark-H

This comment has been minimized.

Copy link
Collaborator

commented Apr 25, 2019

FYI This PR also includes changes already proposed in #14511.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.