Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource checkbox animation #14559

Merged
merged 3 commits into from Apr 27, 2019

Conversation

@ilyautkin
Copy link
Contributor

commented Apr 16, 2019

What does it do?

Fix animation of checkboxes in resource creating/updating page.

Why is it needed?

When we click any resource checkbox (for example, Published), it change state. But type of animation - fading, not slide.
screen-2019-04-16_09 17 22

With this change animation will work correctly:
screen-2019-04-16_09 30 05

Related issue(s)/PR(s)

@Ruslan-Aleev
Copy link
Contributor

left a comment

Everything works )

checkbox

@ilyautkin

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

Switched on slider is moved to the right as everywhere in iOS and Android.

@Mark-H

Mark-H approved these changes Apr 25, 2019

@JoshuaLuckers JoshuaLuckers self-assigned this Apr 25, 2019

@JoshuaLuckers JoshuaLuckers merged commit e1241f6 into modxcms:3.x Apr 27, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.