Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature welcome widget #14569

Open
wants to merge 8 commits into
base: 3.x
from

Conversation

Projects
None yet
7 participants
@sdrenth
Copy link
Contributor

commented Apr 25, 2019

What does it do?

Added a new welcome widget for the dashboard page showing a welcome message and current time. The background image can be changed by the newly added system setting widget_welcome_background.

Why is it needed?

Displays a neat welcome message when visiting the dashboard page.

Screenshot 2019-04-25 at 10 03 17

@sdrenth sdrenth requested review from Mark-H and opengeek as code owners Apr 25, 2019

@Electrica

This comment has been minimized.

Copy link

commented Apr 25, 2019

You are seriously? )))

@Mark-H

This comment has been minimized.

Copy link
Collaborator

commented Apr 25, 2019

Two things:

  • Where is that image from and under what license is it available?
  • Style changes should be made in the sass files (in _build/templates/default/), not the output css file.
@gpsietzema

This comment has been minimized.

Copy link
Collaborator

commented Apr 25, 2019

The image is from Unsplash.

@Mark-H Mark-H added this to the v3.0.0-alpha milestone Apr 25, 2019

@sdrenth

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

@Mark-H I moved to css changes to the sass files

Show resolved Hide resolved _build/templates/default/sass/_dashboard.scss Outdated
Show resolved Hide resolved _build/templates/default/sass/_dashboard.scss Outdated
Show resolved Hide resolved manager/templates/default/css/index-min.css Outdated
Show resolved Hide resolved manager/templates/default/css/login.css Outdated
Show resolved Hide resolved manager/templates/default/css/index.css Outdated

sdrenth added some commits Apr 25, 2019

@JoshuaLuckers

This comment has been minimized.

Copy link
Collaborator

commented Apr 25, 2019

I don't think that a non-functional dashboard widget like this should be in the core.

  1. It's wasting to much useful space
  2. It's showing the time on the server which might confuse users if it deviates from the users time. This can be useful if properly presented to the user.
  3. Do we really want to load more assets like this image in the manager?
@gpsietzema

This comment has been minimized.

Copy link
Collaborator

commented Apr 26, 2019

  1. The point is to make this dashboard prettier. That's an important function. Make people happier to use the system.
  2. Sure, any ideas?
  3. Yes. It's needed for this.
@JoshuaLuckers

This comment has been minimized.

Copy link
Collaborator

commented Apr 26, 2019

  • The point is to make this dashboard prettier. That's an important function. Make people happier to use the system.

Fair enough! The functions provided by the widget in its current state, in my opinion, don't justify the amount of space it uses. I suggest to provide additional functionality personalised for the current user.
I'll propose some ideas later.

  • Sure, any ideas?

Not right now.

  • Yes. It's needed for this.

Haha 🤣. It would be nice to mention the source/link of the image in the code as comment for future reference.

@Alroniks

This comment has been minimized.

Copy link
Collaborator

commented Apr 26, 2019

It would be nice to collect those nice widgets in the separated extra. It will allow us to have them updated separately and more frequently and do not waste the time of core integrations for such small improvements.
It nice and I like it, of course, but from a common perspective and long term view these things will have to be maintained later in case of changes and this will take time away.

@Alroniks

This comment has been minimized.

Copy link
Collaborator

commented Apr 26, 2019

@gpsietzema @sdrenth I can help with creating such extra and I can maintain it if you agree.
Also, as it was described in other issues, a bunch of extras can be suggested user for installation on new setup interface and this extra would be the best candidate for such list.

@gpsietzema

This comment has been minimized.

Copy link
Collaborator

commented Apr 26, 2019

Sounds like a good idea @Alroniks - I really like it.

@sdrenth

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

I've added the source URL of the default image in: transport.core.system_settings.php

@sdrenth

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

@Alroniks Any progress on this one?

Also any thoughts about which widgets should be extracted from the core into an Extra and which should stay in the core?

I feel like most widgets should stay in the core and this one should be added into an extra. But for the extra to also add some more value I feel like there should be some more enhanced dashboard widgets added into that extra. But that could also be something which we could expand later on.

@Alroniks

This comment has been minimized.

Copy link
Collaborator

commented May 24, 2019

I would like to leave only top buttons, security check and feeds (I don't like them but they probably needed).
Others should be and can be moved to the extra.
I have not started anything yet, but it should be done at the same time with adding additional screen for an installer with suggested add-ons. To have it preinstalled and keep a good user experience.

@gpsietzema

This comment has been minimized.

Copy link
Collaborator

commented Jun 7, 2019

@Alroniks You can already start with the dashboard-widgets extra; it doesn't need to depend on the additional installer screen. Is anyone working on that by the way? I know @Mark-H made a mockup once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.