Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving profile edit screen #14578

Open
wants to merge 2 commits into
base: 3.x
from

Conversation

Projects
None yet
3 participants
@sdrenth
Copy link
Contributor

commented May 3, 2019

What does it do?

Refactored the edit account page:
domain.tld/manager/?a=security/profile

  • Moved save buttons from the bottom of the page to the top, to improve consistency
  • Added fields to edit account page: Gender, address, country, city, zipcode and website.
  • Moved change password tab to the General information tab (permissions check is still in place)
  • Every field is now 100% wide, but seperated the view into two columns. Personal details are shown on the left side, address + password are shown on the right side.
  • Removed changepassword processor since its not being used anymore. I've moved the logic to the /profile/update processor.

Why is it needed?

This fixes some missing fields, improves consistency and makes the view more clean.

Preview of the refactored view:
Screenshot 2019-05-03 at 13 08 58

@sdrenth sdrenth requested review from Mark-H and opengeek as code owners May 3, 2019

@Ibochkarev

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

Relayted #14420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.