Fix grouping grid sorting - ACL grids#16529
Merged
opengeek merged 5 commits intomodxcms:3.xfrom Aug 29, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 3.x #16529 +/- ##
============================================
- Coverage 21.57% 21.52% -0.06%
- Complexity 10566 10603 +37
============================================
Files 561 561
Lines 31940 32030 +90
============================================
+ Hits 6892 6895 +3
- Misses 25048 25135 +87 ☔ View full report in Codecov by Sentry. |
Mark-H
reviewed
Feb 26, 2024
331bce5 to
7e12a9f
Compare
theboxer
approved these changes
Aug 21, 2024
Member
theboxer
left a comment
There was a problem hiding this comment.
thx for the updates, I'd say this is good to go now
Remove stale lines brought in during rebase
Formatting, var naming, and other stylistic changes only; no functional changes.
Create new method in base and child UG GetList to improve code structure, as suggested in PR comment. Includes a couple small post-rebase adjustments as well.
3620025 to
297f240
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds new grouping logic to ACL GetList processors and config props in the corresponding Ext grid classes.
Why is it needed?
Aside from the Settings grid,* other grouping grids (such as the ACL ones) neither group properly, nor sort within groups properly.
How to test
Related issue(s)/PR(s)
No related issue.