New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xPDO->addPackage returns true even if xPDO->setPackageMeta fails #145

Open
Mark-H opened this Issue Jul 26, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@Mark-H
Copy link
Collaborator

Mark-H commented Jul 26, 2018

In https://github.com/modxcms/xpdo/blob/3.x/src/xPDO/xPDO.php#L474-L476, changing $added = true; to $added = $this->setPackageMeta will allow calls to addPackage to get the proper true/false dependant on the actual success.

@opengeek

This comment has been minimized.

Copy link
Member

opengeek commented Jul 26, 2018

It should probably log an error, as well.

@opengeek opengeek added this to the 3.0.x-beta milestone Jul 26, 2018

@opengeek opengeek self-assigned this Jul 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment