Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactor Markup & SCSS #40

Merged
merged 61 commits into from Apr 18, 2019

Conversation

@christianseel
Copy link
Contributor

commented Apr 14, 2019

What does it do?

  • simplified markup (semantic markup with less nesting)
  • use BEM classes with namespaces
  • split SCSS into separated files based on use-case/component
  • usage of aria attributes (where needed for increased a11y)
  • better responsive behavior

Why is it needed?

What problem does this solve?

Related issue(s)/PR(s)

If there's a related issue, please add Fixes #<issue number>.

Open enhancements

  • outlines (focus) optimizations for keyboard navigation
  • make TOC sticky if viewport height is large enough (JS enhancement)
  • responsive font sizes (headings?) - see #19

Screenshots

local docs modx org_8888_3 x_en_index (1)

@christianseel christianseel changed the title [WIP] Refactor SCSS [WIP] Refactor Markup & SCSS Apr 15, 2019
@christianseel christianseel referenced this pull request Apr 17, 2019
Mark-H and others added 29 commits Apr 18, 2019
…f versions; disable it in the CLI utils
…tor-scss
…the file path
This creates a cache file for each file for each unique page, leading to an exponential file list that I am most certainly going to regret.
@Mark-H Mark-H merged commit 92176a5 into master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.