New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Delete action for notification #1275

Merged
merged 1 commit into from Aug 9, 2018

Conversation

Projects
None yet
2 participants
@kendling
Contributor

kendling commented Aug 8, 2018

I add delete action in notification settings and make it work.

@moezbhatti

This is fantastic work! I appreciate the effort you put in to ensure that all your new code follows the code style of QKSMS, even though it's not explicitly outlined anywhere

I've just added a couple comments regarding some very minor changes, they should take no more than a couple minutes to address.

I also appreciate that you added all the translations. Just be warned that they might be overwritten when I import the translations available on Crowdin, which is the ultimate source of truth regarding translations. If you'd like to submit your own translations there, feel free to submit them at https://qklabs.com/translations

@moezbhatti

This comment has been minimized.

Show comment
Hide comment
@moezbhatti

moezbhatti Aug 8, 2018

Owner

FYI, made some slight changes to the notification action creation: d84827f

Owner

moezbhatti commented Aug 8, 2018

FYI, made some slight changes to the notification action creation: d84827f

@kendling

This comment has been minimized.

Show comment
Hide comment
@kendling

kendling Aug 9, 2018

Contributor

I was update the things.

Contributor

kendling commented Aug 9, 2018

I was update the things.

@moezbhatti moezbhatti merged commit b69327c into moezbhatti:dev Aug 9, 2018

0 of 2 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment