Skip to content

Mohan Zhang mohanzhang

March 11, 2014
Mohan Zhang
Version 1.6.0
1 commit with 152 additions and 85 deletions
March 11, 2014
March 06, 2014
March 06, 2014
mohanzhang commented on pull request thoughtbot/vim-rspec#49
Mohan Zhang

@DavidVII Awesome! Glad I could help!

March 06, 2014
mohanzhang commented on pull request thoughtbot/vim-rspec#49
Mohan Zhang

@DavidVII Yeah, it's definitely in there: 0941512 If you're using vundler, you might have to use a :BundleUpdate command in vim; alternatively, you…

March 06, 2014
mohanzhang commented on pull request thoughtbot/vim-rspec#49
Mohan Zhang

@DavidVII If you look at the next line down in the README ("iTerm instead of Terminal"), you'll see that it's as simple as setting let g:rspec_runn…

mohanzhang deleted branch iterm2-support at legitscript/vim-rspec
March 06, 2014
March 04, 2014
Mohan Zhang
March 03, 2014
mohanzhang commented on pull request thoughtbot/vim-rspec#49
Mohan Zhang

@gylaz Sorry for the delay. Life kind of happened for a while there :) Let me know if my most recent commit looks ok to you.

March 03, 2014
Mohan Zhang
  • Mohan Zhang 988c114
    Configurable iTerm support for MacVim
February 18, 2014
mohanzhang commented on pull request thoughtbot/vim-rspec#49
Mohan Zhang

@gylaz Yes, I definitely envisioned something like this, but didn't see how I could get a script-scoped variable like s:plugin_path to be read in t…

February 14, 2014
mohanzhang commented on pull request thoughtbot/vim-rspec#49
Mohan Zhang

@gylaz Would still like to get this merged---I'd like to check what I need to do to get this accepted, either: I leave it as my latest change (2948cc6

February 11, 2014
mohanzhang commented on pull request thoughtbot/vim-rspec#49
Mohan Zhang

I left the variable name alone in this update. Still not sure introducing the whole new concept of an all-powerful g:rspec_runner was within the sc…

February 11, 2014
Mohan Zhang
  • Mohan Zhang 2948cc6
    Configurable iTerm support for MacVim
February 10, 2014
mohanzhang commented on pull request thoughtbot/vim-rspec#49
Mohan Zhang

Doh. As I went off to make this change, I realized another reason I chose g:rspec_terminal: in the code, I am using this variable to complete the s…

February 10, 2014
mohanzhang commented on pull request thoughtbot/vim-rspec#49
Mohan Zhang

Right, I see. A coworker pointed out that one potential use in favor of something like g:rspec_runner is that you might have a custom script that r…

February 10, 2014
mohanzhang commented on pull request thoughtbot/vim-rspec#49
Mohan Zhang

I definitely spent a while thinking about the correct name for this variable. In the end I went with g:rspec_terminal because it most accurately de…

February 10, 2014
mohanzhang commented on pull request thoughtbot/vim-rspec#49
Mohan Zhang

Agreed. Will fix.

February 08, 2014
February 08, 2014
mohanzhang commented on pull request thoughtbot/vim-rspec#49
Mohan Zhang

This is similar in spirit to #25 but I made this change in a way that made sense to me.

February 08, 2014
mohanzhang opened pull request thoughtbot/vim-rspec#49
Mohan Zhang
Configurable iTerm support
1 commit with 38 additions and 1 deletion
February 08, 2014
February 06, 2014
Mohan Zhang
January 28, 2014
Mohan Zhang
  • Mohan Zhang 55c6cee
    vim: add ack and syntastic
January 04, 2014
Mohan Zhang
  • Mohan Zhang fb53e34
    Update README with instructions
January 04, 2014
mohanzhang created repository dappernews
January 04, 2014
January 03, 2014
Mohan Zhang
  • Mohan Zhang 9036afc
    Fix lyric in The Ocean Spins Backwards
mohanzhang created branch master at mohanzhang/music
January 03, 2014
mohanzhang created repository music
January 03, 2014
Something went wrong with that request. Please try again.