New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added =encoding utf8 to pass Test::Pod/Kwalitee tests. Added t/pod.t #1

Closed
wants to merge 9 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@fozzmoo
Contributor

fozzmoo commented Feb 6, 2015

No description provided.

@mohawk2

This comment has been minimized.

Owner

mohawk2 commented Feb 27, 2015

Thanks for the PR, which I have merged.

Bit of a shame that despite the commit message, you didn't actually correct the POD (including changing the copyright character to being UTF-8 encoded), or add Test::Pod as a requirement to Makefile.PL.

@mohawk2 mohawk2 closed this Feb 27, 2015

@fozzmoo

This comment has been minimized.

Contributor

fozzmoo commented Feb 27, 2015

On Fri, 27 Feb 2015 12:20:35 -0800
mohawk2 notifications@github.com wrote:

Thanks for the PR, which I have merged.

Bit of a shame that despite the commit message, you didn't actually
correct the POD (including changing the copyright character to being
UTF-8 encoded), or add Test::Pod as a requirement to Makefile.PL.

I am ashamed. Despite your heaps of discouragement, I will continue to try
to contribute, as little as I do, to Perl projects.

Doran L. Barton doran@bluehost.com - Senior Developer at Bluehost
"Please call us! We will provide you with any emergency "
-- Ad for babysitting service in Japan

@mohawk2

This comment has been minimized.

Owner

mohawk2 commented Feb 27, 2015

Your contribution is highly welcome! For this (and your other one), it seemed easier to just fix rather than ask you to change and resubmit, is all. However, I trust you will take on board the points made in my comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment