Skip to content
Permalink
Browse files Browse the repository at this point in the history
security fix for CVE-2017-5934, XSS in GUI editor related code
Thanks to Nitin Venkatesh for discovering and reporting this!
  • Loading branch information
ThomasWaldmann committed Sep 9, 2018
1 parent 301b1a2 commit 70955a8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 2 additions & 1 deletion MoinMoin/action/fckdialog.py
Expand Up @@ -203,6 +203,7 @@ def page_list(request):
def link_dialog(request):
# list of wiki pages
name = request.values.get("pagename", "")
name_escaped = wikiutil.escape(name)
if name:
from MoinMoin import search
# XXX error handling!
Expand Down Expand Up @@ -299,7 +300,7 @@ def link_dialog(request):
<tr>
<td>
<span fckLang="PageDlgName">Page Name</span><br>
<input id="txtPagename" name="pagename" size="30" value="%(name)s">
<input id="txtPagename" name="pagename" size="30" value="%(name_escaped)s">
</td>
<td valign="bottom">
<input id=btnSearchpage type="submit" value="Search">
Expand Down
1 change: 1 addition & 0 deletions docs/CHANGES
Expand Up @@ -23,6 +23,7 @@ Version 1.9.10 aka "the end of spam release" (not released yet)
should be aware of beforehands.

Fixes:
* security fix for CVE-2017-5934, XSS in GUI editor related code
* fix wrong digestmod of hmac.new calls (incorporate 1.9.9 patch)
* fix broken table attribute processing (wikiutil.escape)
* fix AttributeError in multifile action
Expand Down

0 comments on commit 70955a8

Please sign in to comment.