Make use of meta data key constants #1959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+25
to
+37
| from moin.constants.keys import ( | ||
| CONTENTTYPE, | ||
| CURRENT, | ||
| ITEMID, | ||
| DATAID, | ||
| NAMESPACE, | ||
| REVID, | ||
| SIZE, | ||
| PARENTID, | ||
| REV_NUMBER, | ||
| MTIME, | ||
| NAME, | ||
| ) |
Member
There was a problem hiding this comment.
Maybe rather use 2 lines with 2 import statements than this vertical formatting?
Member
There was a problem hiding this comment.
Hmm, that also already existed at some other places, so maybe ignore it for this PR.
Contributor
Author
There was a problem hiding this comment.
This is the result of auto-formatting by black.
roland-ruedenauer
force-pushed
the
use-meta-data-key-constants
branch
from
65391e7 to
f6d8416
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.