Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

myql table scanner cannot stop if source db deletes data #11

Closed
ming535 opened this issue Jan 2, 2019 · 2 comments · Fixed by #102
Closed

myql table scanner cannot stop if source db deletes data #11

ming535 opened this issue Jan 2, 2019 · 2 comments · Fixed by #102
Assignees
@ming535
Milestone
1.0

Comments

@ming535
Copy link
Contributor

ming535 commented Jan 2, 2019 •
edited
Loading

We should consider start a snapshot consistent read.
@ming535 ming535 self-assigned this Jan 2, 2019
@Ryan-Git
Copy link
Collaborator

Ryan-Git commented Jan 2, 2019

it would be too expensive for large tables, and make parallel fetch quite difficult, if not impossible.

I'd prefer a local comparison along with an optional remote one for non-numeric columns(e.g. select 'abc'>'abcd') instead.

@ming535 ming535 added this to the 1.0 milestone Jan 28, 2019
@Ryan-Git
Copy link
Collaborator

Ryan-Git commented Feb 15, 2019 •
edited
Loading

Why it cannot stop? We'll finish the task if no rows returned from query.

gravity/pkg/inputs/mysqlbatch/mysql_table_scanner.go

Line 224 in bb84413

if rowIdx == 0 {

@ming535 ming535 mentioned this issue Mar 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ming535 ming535

Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

mysqlbatch done and composite primary key moiot/gravity
2 participants
@Ryan-Git @ming535