From 2dac586fd1cba391cbd6a0b4062eaf3a2cff8da4 Mon Sep 17 00:00:00 2001
From: Josh Rowe <josh.rowe@digital.justice.gov.uk>
Date: Fri, 1 Nov 2019 14:18:15 +0000
Subject: [PATCH] Add coverage to github actions

---
 .github/workflows/pythonpackage.yml |  8 ++++++--
 dataengineeringutils3/writer.py     |  1 +
 poetry.lock                         | 12 ++++++------
 pyproject.toml                      |  1 +
 setup.cfg                           | 11 +++++++++++
 5 files changed, 25 insertions(+), 8 deletions(-)
 create mode 100644 setup.cfg

diff --git a/.github/workflows/pythonpackage.yml b/.github/workflows/pythonpackage.yml
index 3004666..410b2b5 100644
--- a/.github/workflows/pythonpackage.yml
+++ b/.github/workflows/pythonpackage.yml
@@ -30,7 +30,11 @@ jobs:
         # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
         flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
     - name: Test with pytest
+      env:
+        COVERALLS_REPO_TOKEN: ${{ secrets.github_token }}
+        COVERALLS_SERVICE_NAME: github
       run: |
-        pip install pytest pytest-cov poetry
+        pip install pytest pytest-cov poetry boto3 moto coveralls
         poetry install
-        pytest --cov-report term-missing --cov=dataengineeringutils3 tests/
+        pytest --cov=dataengineeringutils3 tests/
+        coveralls
diff --git a/dataengineeringutils3/writer.py b/dataengineeringutils3/writer.py
index 03c8806..f03fc93 100644
--- a/dataengineeringutils3/writer.py
+++ b/dataengineeringutils3/writer.py
@@ -72,4 +72,5 @@ class JsonNlSplitFileWriter(SplitFileWriter):
     extension = ".jsonl.gz"
 
     def _write(self, file_path):
+        """Gzip string to file path in s3"""
         gzip_string_write_to_s3(self.string, file_path)
diff --git a/poetry.lock b/poetry.lock
index f49b25b..7954455 100644
--- a/poetry.lock
+++ b/poetry.lock
@@ -55,10 +55,10 @@ description = "The AWS SDK for Python"
 name = "boto3"
 optional = false
 python-versions = "*"
-version = "1.10.4"
+version = "1.10.7"
 
 [package.dependencies]
-botocore = ">=1.13.4,<1.14.0"
+botocore = ">=1.13.7,<1.14.0"
 jmespath = ">=0.7.1,<1.0.0"
 s3transfer = ">=0.2.0,<0.3.0"
 
@@ -68,7 +68,7 @@ description = "Low-level, data-driven core of boto 3."
 name = "botocore"
 optional = false
 python-versions = "*"
-version = "1.13.4"
+version = "1.13.7"
 
 [package.dependencies]
 docutils = ">=0.10,<0.16"
@@ -628,7 +628,7 @@ version = "4.6.0"
 setuptools = "*"
 
 [metadata]
-content-hash = "7661b729cac76acf3f0ce6eefc146cbf01449393d010c60126189141406190a0"
+content-hash = "9ffd09b73776fbb1e8e1d4220643f2935ddb6d26b50ec939cc5eae7acf8ea89a"
 python-versions = "^3.7"
 
 [metadata.hashes]
@@ -637,8 +637,8 @@ attrs = ["08a96c641c3a74e44eb59afb61a24f2cb9f4d7188748e76ba4bb5edfa3cb7d1c", "f7
 aws-sam-translator = ["11c62c00f37b57c39a55d7a29d93f4704a88549c29a6448ebc953147173fbe85"]
 aws-xray-sdk = ["75cbce8c777b7d8055719ee1a0db6043e53c44e8f1a62a956bd84db87c4a4c7c", "ce4adb60fe67ebe91f2fc57d5067b4e44df6e233652987be4fb2e549688cf9fe"]
 boto = ["147758d41ae7240dc989f0039f27da8ca0d53734be0eb869ef16e3adcfa462e8", "ea0d3b40a2d852767be77ca343b58a9e3a4b00d9db440efb8da74b4e58025e5a"]
-boto3 = ["63b80dd065221a3143f80559392769a94c303e616bdb956d66685cd3160d409e", "bf315a5aafab7e429ed08acce36f4c50de18024b1087e5050d5b7f0681862549"]
-botocore = ["3773a28e139ccd41435afe64ee5945e5ccd1b84706f54bcb971788d71f7f138c", "efd131a59107ceb3c9a0f885d947f1b150ab68a875bbec05004d9768e45e6a0f"]
+boto3 = ["3f8e0517760b8d3c03d72edd9f9e6dbd6974446fba8fc931fd174720651ba7d5", "d0cc24b5199b8ee4d0330a3245c377c45e2435cd7b190ce8d485f5f9a9ae8c40"]
+botocore = ["3601ad3bc81ae87481572bbbe753f5177e5e380f86f184a9e95b3164710d616f", "a2905b7c916e30469be6912b9e1a4361116b1ea35618876fdb621b160d13e095"]
 certifi = ["e4f3620cfea4f83eedc95b24abd9cd56f3c4b146dd0177e83a21b4eb49e21e50", "fd7c7c74727ddcf00e9acd26bba8da604ffec95bf1c2144e67aff7a8b50e6cef"]
 cffi = ["00d890313797d9fe4420506613384b43099ad7d2b905c0752dbcc3a6f14d80fa", "0cf9e550ac6c5e57b713437e2f4ac2d7fd0cd10336525a27224f5fc1ec2ee59a", "0ea23c9c0cdd6778146a50d867d6405693ac3b80a68829966c98dd5e1bbae400", "193697c2918ecdb3865acf6557cddf5076bb39f1f654975e087b67efdff83365", "1ae14b542bf3b35e5229439c35653d2ef7d8316c1fffb980f9b7647e544baa98", "1e389e069450609c6ffa37f21f40cce36f9be7643bbe5051ab1de99d5a779526", "263242b6ace7f9cd4ea401428d2d45066b49a700852334fd55311bde36dcda14", "33142ae9807665fa6511cfa9857132b2c3ee6ddffb012b3f0933fc11e1e830d5", "364f8404034ae1b232335d8c7f7b57deac566f148f7222cef78cf8ae28ef764e", "47368f69fe6529f8f49a5d146ddee713fc9057e31d61e8b6dc86a6a5e38cecc1", "4895640844f17bec32943995dc8c96989226974dfeb9dd121cc45d36e0d0c434", "558b3afef987cf4b17abd849e7bedf64ee12b28175d564d05b628a0f9355599b", "5ba86e1d80d458b338bda676fd9f9d68cb4e7a03819632969cf6d46b01a26730", "63424daa6955e6b4c70dc2755897f5be1d719eabe71b2625948b222775ed5c43", "6381a7d8b1ebd0bc27c3bc85bc1bfadbb6e6f756b4d4db0aa1425c3719ba26b4", "6381ab708158c4e1639da1f2a7679a9bbe3e5a776fc6d1fd808076f0e3145331", "6fd58366747debfa5e6163ada468a90788411f10c92597d3b0a912d07e580c36", "728ec653964655d65408949b07f9b2219df78badd601d6c49e28d604efe40599", "7cfcfda59ef1f95b9f729c56fe8a4041899f96b72685d36ef16a3440a0f85da8", "819f8d5197c2684524637f940445c06e003c4a541f9983fd30d6deaa2a5487d8", "825ecffd9574557590e3225560a8a9d751f6ffe4a49e3c40918c9969b93395fa", "8a2bcae2258d00fcfc96a9bde4a6177bc4274fe033f79311c5dd3d3148c26518", "9009e917d8f5ef780c2626e29b6bc126f4cb2a4d43ca67aa2b40f2a5d6385e78", "9c77564a51d4d914ed5af096cd9843d90c45b784b511723bd46a8a9d09cf16fc", "a19089fa74ed19c4fe96502a291cfdb89223a9705b1d73b3005df4256976142e", "a40ed527bffa2b7ebe07acc5a3f782da072e262ca994b4f2085100b5a444bbb2", "b8f09f21544b9899defb09afbdaeb200e6a87a2b8e604892940044cf94444644", "bb75ba21d5716abc41af16eac1145ab2e471deedde1f22c6f99bd9f995504df0", "e22a00c0c81ffcecaf07c2bfb3672fa372c50e2bd1024ffee0da191c1b27fc71", "e55b5a746fb77f10c83e8af081979351722f6ea48facea79d470b3731c7b2891", "ec2fa3ee81707a5232bf2dfbd6623fdb278e070d596effc7e2d788f2ada71a05", "fd82eb4694be712fcae03c717ca2e0fc720657ac226b80bbb597e971fc6928c2"]
 cfn-lint = ["6d32de719943f2cf1f2e8edf6ab1893764bb66dcbb78718540711bd9a0711bff", "9ff6aaee29faae063006be2740a34c141f75512c0f237cd842eb3c76890cd66c"]
diff --git a/pyproject.toml b/pyproject.toml
index 8fa477d..a8aad71 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -24,6 +24,7 @@ boto3 = "^1.10"
 pytest = "^3.4"
 moto = "^1.3"
 pytest-cov = "^2.8"
+boto3 = "^1.10"
 
 [build-system]
 requires = ["poetry>=0.12"]
diff --git a/setup.cfg b/setup.cfg
new file mode 100644
index 0000000..2180733
--- /dev/null
+++ b/setup.cfg
@@ -0,0 +1,11 @@
+[flake8]
+exclude = .git/, .github/, */__init__.py
+max-complexity = 10
+max-line-length = 80
+
+[coverage:run]
+omit =
+    */__init__.py
+
+[coverage:report]
+show_missing = True