Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CML Action to run whole workflow #132

Merged
merged 221 commits into from Aug 13, 2022
Merged

Add CML Action to run whole workflow #132

merged 221 commits into from Aug 13, 2022

Conversation

radistoubalidis
Copy link
Contributor

Description

Goals

  • Update action to run the whole simulation
  • Add GCBM.CompileResults tool to the docker image
  • Compare numerical results and log files with HEAD

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

...

Additional Context (Please include any Screenshots/gifs if relevant)

  • Using the script written by Namyalg to retrieve the log files

radistoubalidis and others added 30 commits April 8, 2022 13:20
@radistoubalidis
reproduce FLINT.Cloud apis
a3df322
@radistoubalidis
changed form data paths
f1af387
@radistoubalidis
Merge pull request #1 from radistoubalidis/reproduce
3765331 
reproduce FLINT.Cloud apis
@radistoubalidis
example sim report using cml
14ea019
@radistoubalidis
Update cml-report.yml
486184a
@radistoubalidis
Update cml-report.yml
93cb748
@radistoubalidis
Update cml-report.yml
29138c0
@radistoubalidis
Update cml-report.yml
4991cf4
@radistoubalidis
Update cml-report.yml
7eb9cf6
@radistoubalidis
Update cml-report.yml
0d89ef4
@radistoubalidis
Update cml-report.yml
6b21e96
@radistoubalidis
test if cml is setup right
52e8445
@radistoubalidis
Merge branch 'master' of github.com:radistoubalidis/FLINT.Cloud into …
806fdad 
…integrate_cml
@radistoubalidis
add cml script
66e8192
@radistoubalidis
Update cml-report.yml
ba03306
@radistoubalidis
changed file paths to not show local directories
5f59877
@radistoubalidis
Merge branch 'master' of github.com:radistoubalidis/FLINT.Cloud into …
a29fd30 
…integrate_cml
@radistoubalidis
update cml report
6266c5e
@radistoubalidis
setup gha script to show summary
437622f
@radistoubalidis
Update cml-report.yml
472a51d
@radistoubalidis
Merge branch 'master' of github.com:radistoubalidis/FLINT.Cloud into …
81e5bdd 
…integrate_cml
@radistoubalidis
setup GCBM summary
11b6ef7
@radistoubalidis
setup GCBM summary
0ffe4a9
@radistoubalidis
setup GCBM summary
49473c7
@radistoubalidis
setup GCBM summary
d109e1e
@radistoubalidis
setup GCBM summary
c4dc48c
@radistoubalidis
setup GCBM summary
88e78c4
@radistoubalidis
setup GCBM summary
6a33fae
@radistoubalidis
setup GCBM summary
36ebf49
@radistoubalidis
setup GCBM summary
2c12120
radistoubalidis and others added 11 commits August 4, 2022 11:29
@radistoubalidis
Merge branch 'moja-global:master' into sim_summary
cd6ee22
@radistoubalidis
Test CML Action with linux-demo.zip as configuration
4cdea9f 
Signed-off-by: radis toubalidis <rtoumpalidis@gmail.com>
@radistoubalidis
Test CML Action with linux-demo.zip as configuration
ec1c919 
Signed-off-by: radis toubalidis <rtoumpalidis@gmail.com>
@radistoubalidis
Test CML Action with linux-demo.zip as configuration
47ad7ed 
Signed-off-by: radis toubalidis <rtoumpalidis@gmail.com>
@radistoubalidis
Test CML Action with linux-demo.zip as configuration
b373392 
Signed-off-by: radis toubalidis <rtoumpalidis@gmail.com>
@radistoubalidis
Test CML Action with linux-demo.zip as configuration
3a35fdf 
Signed-off-by: radis toubalidis <rtoumpalidis@gmail.com>
@radistoubalidis
Test CML Action with linux-demo.zip as configuration
562b11d 
Signed-off-by: radis toubalidis <rtoumpalidis@gmail.com>
@radistoubalidis
Test CML Action with linux-demo.zip as configuration
af25046 
Signed-off-by: radis toubalidis <rtoumpalidis@gmail.com>
@radistoubalidis
Test CML Action with linux-demo.zip as configuration
69f700c 
Signed-off-by: radis toubalidis <rtoumpalidis@gmail.com>
@radistoubalidis
Test CML Action with linux-demo.zip as configuration
92b2678 
Signed-off-by: radis toubalidis <rtoumpalidis@gmail.com>
@radistoubalidis
Test CML Action with linux-demo.zip as configuration
03832a3 
Signed-off-by: radis toubalidis <rtoumpalidis@gmail.com>
@radistoubalidis
Copy link
Contributor Author

radistoubalidis commented Aug 4, 2022 •
edited

In 03832a3 :

  • I modified CML Action to run the GCBM simulation without using the rest_gcbm_api .

  • The simulation runs smoothly the job fails in the cml step because forks can't publish comments in a PR.

  • You can see full action output here

aornugent
aornugent reviewed Aug 5, 2022
View reviewed changes
.github/workflows/cml-report.yml Outdated
docker exec -i gcbm python GCBM.CompileResults/compileresults.py sqlite:///tests/output/gcbm_output.db --output_db sqlite:///tests/output/compiled_simulation_output.db
docker cp -L gcbm:/app/tests/output/compiled_simulation_output.db local/rest_api_gcbm/tests

- name: Setup CML
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure the rest_api_gcbm container already has CML installed - this action generates the statement "Uninstalling existing CML installation", so I think it can be removed.

@HarshCasper HarshCasper force-pushed the sim_summary branch 2 times, most recently from 16ca286 to 22d8b37 Compare August 6, 2022 18:15
HarshCasper
HarshCasper previously approved these changes Aug 6, 2022
View reviewed changes
radistoubalidis
radistoubalidis commented Aug 8, 2022
View reviewed changes
Copy link
Contributor Author

@radistoubalidis radistoubalidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HarshCasper should I uncomment the label line in the yml file ?

aornugent
aornugent requested changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@aornugent aornugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @radistoubalidis and @HarshCasper - I know this was frustrating to debug.

I can't tell what changes have occurred to linux-demo.zip but given that this was the source of our previous difficulties I'll ask you to remove it from this PR.

.github/workflows/cml-report.yml Show resolved Hide resolved
.github/workflows/cml-report.yml Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
.github/workflows/cml-report.yml
cd local/rest_api_gcbm
python3 GCBM.CompileResults/compileresults.py sqlite:///tests/output/gcbm_output.db --output_db sqlite:///tests/output/compiled_simulation_output.db

- name: Install dependencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these would be fine to add to rest_api_gcbm too - maybe even CML while we're at it?

@aornugent
Copy link
Contributor

PS please make sure to squash merge 😅

aornugent
aornugent previously approved these changes Aug 13, 2022
View reviewed changes
@HarshCasper HarshCasper dismissed stale reviews from aornugent and themself via 81953ef August 13, 2022 16:21
@HarshCasper HarshCasper merged commit c363558 into moja-global:master Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshCasper HarshCasper HarshCasper approved these changes

@aornugent aornugent aornugent left review comments

Assignees
No one assigned
Labels
DevOps GCBM run-simulation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@radistoubalidis @HarshCasper @aornugent