Feature/markdown documents #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create Encryption document in Markdown format - Added new Encryption document to SUMMARY.md for publishing.
…fication - Updated Encryption.md ToF to remove "double" bullet points. - Create Glossary.md document in Markdown format. - Updated README.md to reference Glossary.md and Encryption.md documents. - Updated SUMMARY.md to reference Glossary.md. - Updated release to v8.6.4.
…cation. Updated the height of participant boxes to be the same within a diagram. Used the same naming standard for participants across diagrams. Set default font as "Verdana" - this is a true web font. Update all diagrams to include a "white space" between HTTP code and description. Included 'hide footbox'. Correct misspellings of "commission".
- JSON Binding Rules, - Generic Transaction Patterns. - Created the following sequence diagrams required in the documents; - figure63a.plantuml, - figure64a.plantuml, - figure65a.plantuml, - figure66a.plantuml. - Updated the following sequence diagrams; - figure63.plantuml, - figure64.plantuml, - figure65.plantuml, - figure66.plantuml. increase version to 8.8.1
…mat. Version too 8.8.1.
…cation into feature/markdownDocuments # Conflicts: # assets/diagrams/sequence/figure64.plantuml # assets/diagrams/sequence/figure65.plantuml # assets/diagrams/sequence/figure66.plantuml # package-lock.json # package.json
…cation into feature/markdownDocuments
• Fixed - 5.1.6.9 ATM-Initiated Cash-Out** <-- two stars (*) after section name
• Fixed - two delays added in Figure 34, between "Payer fee is 1 USD in Payer FSP for ATM Cash-Out, total fee 2 USD" and "OTP is pre-generated", and similarly between "Validate OTP sent by Payee FSP, OTP OK" and "Reserve 102 USD from Payer account, 101 USD to Switch account, 1 USD to fee account". There should not be any delays. This seems to be present in other figures as well (for example Figure 36, 46, 51, 52, 66).
• Fixed - Some extra whitespace in at least Figure 34 and 36 in "PUT /transfers/" between the "PUT /transfers/" and "".
• Fixed - Misspelling in Figure 36, "Generated OTP, "12345"" should be "Generate OTP, "12345""
• Fixed - Listing 12 is strange with double * instead of bold.
• Fixed - 6.3.4.1, "Alternative URI: PUT /parties/{Type}/{ID}/{SubId}/error**" <-- double *
• Fixed - 7.2.3.1 Regular Expression** <-- double **
• Fixed - 7.2.4.1 Regular Expression** <-- double **
• Fixed - 7.2.5.1 Regular Expression** <-- double **
…cation into feature/markdownDocuments # Conflicts: # assets/diagrams/sequence/figure34.plantuml # assets/diagrams/sequence/figure36.plantuml # assets/diagrams/sequence/figure46.plantuml # assets/diagrams/sequence/figure51.plantuml # assets/diagrams/sequence/figure52.plantuml # assets/diagrams/sequence/figure65.plantuml # assets/diagrams/sequence/figure66.plantuml
…cation into feature/markdownDocuments
… diagrams. Create "Scheme Rules" in markdown. Updated SUMMARY.md with new document for rendering in GitBooks. Updated README.md file to reference to markdown documents. Removed duplicated section in README.md Updated version to 9.1.1.
HenkKodde
requested review from
elnyry-sam-k,
matthewbohan,
MichaelJBRichards and
millerabel
as code owners
HenkKodde
removed request for
millerabel,
matthewbohan and
MichaelJBRichards
elnyry-sam-k
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create "Scheme Rules" in markdown.
Create "figure1_http_timeout" and "figure2_callback_timeout" sequence diagrams.
Updated SUMMARY.md with new document for rendering in GitBooks.
Updated README.md file to reference to markdown documents.
Removed duplicated section in README.md
Updated version to 9.1.1.