Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate and update the onboarding documentation #784

Closed
15 of 22 tasks
lewisdaly opened this issue May 23, 2019 · 8 comments
Closed
15 of 22 tasks

Consolidate and update the onboarding documentation #784

lewisdaly opened this issue May 23, 2019 · 8 comments
Labels

Comments

@lewisdaly
Copy link
Contributor

lewisdaly commented May 23, 2019

Goal:

As a developer I want to consolidate and update the onboarding docs to improve the onboarding experience for new developers.

At the moment, most of the major sub-projects has it's own Onboarding.md file. Some of them are out of date, are missing information, or are a little redundant.

Tasks:

  • consolidate and update the Onboarding.md files to a single Onboarding file in the mojaloop/mojaloop project. Someone suggest a better place if they would like
  • update local installation guides for:
    • Linux
    • MacOS
    • Windows
  • Update and simplify the Onboarding.md docs in the following repos to link to this new common Onboarding file.
    • ml-api-adapter
    • central-ledger
      - [ ] central-directory - not worth the time since it will soon be deprecated
    • central-end-user-registry
    • central-event-processor
    • quoting-service

- [ ] update other links in docs that refer to individual Onboarding docs Not necessary, as we are keeping the current links and pointing back to the unified onboarding doc.

  • fix the link in mojaloop/docs to refer to this new unified onboarding doc. [Should be somewhere in mojaloop/documentation now] pr pending

Acceptance Criteria:

  • Documentation style meets standards
  • After reading through new onboarding doc, new contributors will have all the steps necessary to get up and running with Mojaloop locally
  • All links will be up-to-date

Pull Requests:

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

@lewisdaly
Copy link
Contributor Author

Does it make sense to delete the individual onboarding docs as they could be superseded by this new one? Or is it preferable to keep the existing docs, and link to the new consolidated one?

@elnyry-sam-k
Copy link
Member

Preferably we just leverage the existing ones and use them with links instead of getting rid of them altogether, I think...

@lewisdaly
Copy link
Contributor Author

Most of the onboarding docs refer to MySQLWorkbench, eg.
https://github.com/mojaloop/central-ledger/blob/master/Onboarding.md#installing-mysqlworkbench

Is there really any need for this MySQLWorkbench? Is is something that all the developers are using?

@lewisdaly
Copy link
Contributor Author

MacOS prs are merged in, and I'm working on the linux instructions now. @RobReeve is going to help with the Windows instructions.

@mdebarros
Copy link
Member

@lewisdaly let me know if you need a Windows VM to do any testing. I can set one up for you if required on our cloud host.

@elnyry-sam-k elnyry-sam-k removed this from the Sprint 6.4 milestone Jun 29, 2019
@lewisdaly
Copy link
Contributor Author

@mdebarros yes please.

@elnyry This is still in progress - I've almost finished going through the installs for Linux, but I just need a windows vm to test the steps for windows on.

@lewisdaly lewisdaly removed their assignment Aug 6, 2019
@lewisdaly
Copy link
Contributor Author

We're run into a roadblock with the Windows instructions: the virtualized environment we set up on AWS to test the docker commands doesn't work as AWS doesn't support nested virtualization.

I'm going to a unassign this now, and hopefully we either resolve the issues with a virtual windows environment, or somebody who has a windows machine can pick this up.

@elnyry-sam-k
Copy link
Member

@lewisdaly we have #844 for windows, so can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants