New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump the game's dialogue #30

Merged
merged 7 commits into from Dec 28, 2017

Conversation

Projects
None yet
2 participants
@Sanqui

Sanqui commented Dec 27, 2017

I also removed some cruft. You'll need to use latest rgbds now.

Sanqui added some commits Dec 27, 2017

Switch to rgbds overlay
It is no longer necessary to include banks or data that has
not been disassembled yet.

This may require a new version of rgbds.
Remove src/disassembled-banks
This only gets in the way of doing `git grep`.  Best
to generate and keep it locally if you need it
@kemenaran

This comment has been minimized.

Collaborator

kemenaran commented Dec 27, 2017

That look awesome, thanks for the work!

I'm currently traveling, and won't be able to merge this before one week or two – but I just had a quick look through it, and it looks great.

@Sanqui

This comment has been minimized.

Sanqui commented Dec 27, 2017

Thanks! There's certainly no hurry. I might be doing more text-related stuff or I might drop it entirely for a few months, with me you never know.

@kemenaran

This comment has been minimized.

Collaborator

kemenaran commented Dec 28, 2017

I took some time to have a look today, and it looks great. Nice to get the dialogs dumped, and the build process improved with rgbds overlays.

@kemenaran kemenaran merged commit 7ce514b into mojobojo:master Dec 28, 2017

@kemenaran

This comment has been minimized.

Collaborator

kemenaran commented Dec 28, 2017

Merged. Thanks for the PR!

By the way, I'm still struggling with producing valid (uncommented) disassembly for the remaining banks. For now I'm working on upgrading pret's pokemon disassembling tools to produce a valid (and symbols-aware) disassembly. It kind of works, but the base code of the disassembler is such an untested mess I wonder if I should start from scratch. If you have any hints or tools, I'm definitely looking for alternatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment