[FIXED #33] allow config to not fail the build on violations #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
reviewed
Aug 7, 2017
| * | ||
| */ | ||
| @Parameter( defaultValue = "true", property = "animal.sniffer.error" ) | ||
| protected boolean error; |
| } | ||
| else | ||
| { | ||
| getLog().info( |
|
Agree all. Let me rework. |
|
The ant task should offer the same parameter. |
don-vip
added a commit
to don-vip/animal-sniffer
that referenced
this pull request
Sep 17, 2017
floscher
pushed a commit
to floscher/josm
that referenced
this pull request
Sep 17, 2017
* fix javadoc issues in deprecated comments * update `animal-sniffer-ant-tasks` to 1.16 + patch to make it not fail the build (see mojohaus/animal-sniffer#34) * update the `check-plugins` task, make it not fail the build git-svn-id: https://josm.openstreetmap.de/svn/trunk@12873 0c6e7542-c601-0410-84e7-c038aed88b3b
simon04
pushed a commit
to JOSM/josm
that referenced
this pull request
Sep 17, 2017
* fix javadoc issues in deprecated comments * update `animal-sniffer-ant-tasks` to 1.16 + patch to make it not fail the build (see mojohaus/animal-sniffer#34) * update the `check-plugins` task, make it not fail the build git-svn-id: http://josm.openstreetmap.de/svn/trunk@12873 0c6e7542-c601-0410-84e7-c038aed88b3b
don-vip
added a commit
to don-vip/animal-sniffer
that referenced
this pull request
Sep 10, 2018
don-vip
added a commit
to don-vip/animal-sniffer
that referenced
this pull request
Sep 10, 2018
olamy
pushed a commit
that referenced
this pull request
Dec 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows a new configuration property 'error' which is true by default to maintain current behavior. The new property lets users not fail the build if errors are found, but simply to allow the error messages to be shown.