Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to put $JAVA_OPTS after <jvmSettings> values in scripts #48

Open
nezda opened this issue Oct 3, 2016 · 0 comments
Open

Option to put $JAVA_OPTS after <jvmSettings> values in scripts #48

nezda opened this issue Oct 3, 2016 · 0 comments

Comments

@nezda
Copy link

nezda commented Oct 3, 2016

Currently

                        <program>
                            <mainClass>com.foo.Server</mainClass>
                            <id>foo-server</id>
                            <jvmSettings>
                                <maxMemorySize>8g</maxMemorySize>
                            </jvmSettings>
                        </program>

generates scripts including

exec "$JAVACMD" $JAVA_OPTS -Xmx8g \
  -classpath "$CLASSPATH" \

It would be useful if the environment variable $JAVA_OPTS could override Xmx by providing a duplicate JVM flag with a different value (-Xmx16g). It is weird to have duplicate values for a given JVM flag, and resulting behavior surely varies across JVMs, but nonetheless, this would be useful as an option to customize a deployment for a server using only environment variables.

With this new flag (javaOptsAfterJvmSettings?), the generated script would include

exec "$JAVACMD" -Xmx8g $JAVA_OPTS \
  -classpath "$CLASSPATH" \
nezda added a commit to nezda/appassembler that referenced this issue Mar 27, 2017
…st and has a chance for its values to take precedence
@nezda nezda mentioned this issue Mar 27, 2017
nezda added a commit to nezda/appassembler that referenced this issue Mar 28, 2017
…st and has a chance for its values to take precedence
@nezda nezda mentioned this issue Mar 28, 2017
nezda added a commit to nezda/appassembler that referenced this issue Mar 29, 2017
…st and has a chance for its values to take precedence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant