From 920636fd86b00904f81d0780d7281cb1bd775125 Mon Sep 17 00:00:00 2001 From: sseifert Date: Fri, 14 Feb 2020 11:12:17 +0100 Subject: [PATCH 1/2] #81 add integration test to execute released-version goal --- src/it/released-version/invoker.properties | 2 + src/it/released-version/pom.xml | 64 +++++++++++++++++++ src/it/released-version/verify.groovy | 9 +++ .../mojo/buildhelper/ReleasedVersionMojo.java | 3 + 4 files changed, 78 insertions(+) create mode 100644 src/it/released-version/invoker.properties create mode 100644 src/it/released-version/pom.xml create mode 100644 src/it/released-version/verify.groovy diff --git a/src/it/released-version/invoker.properties b/src/it/released-version/invoker.properties new file mode 100644 index 00000000..2cf67a98 --- /dev/null +++ b/src/it/released-version/invoker.properties @@ -0,0 +1,2 @@ +invoker.goals = test +invoker.buildResult = success \ No newline at end of file diff --git a/src/it/released-version/pom.xml b/src/it/released-version/pom.xml new file mode 100644 index 00000000..22ebae32 --- /dev/null +++ b/src/it/released-version/pom.xml @@ -0,0 +1,64 @@ + + 4.0.0 + + org.codehaus.mojo + build-helper-maven-plugin-released-version-it + 1.0-SNAPSHOT + build-helper-maven-plugin-released-version-it + + + package + + + @project.groupId@ + @project.artifactId@ + @project.version@ + + + released-version + + released-version + + + myReleasedVersion + + + + + + maven-antrun-plugin + + + mk-target-dir + compile + + run + + + + + + + + + + echo-released-version + test + + run + + + + myReleasedVersion.version=${myReleasedVersion.version} + myReleasedVersion.majorVersion=${myReleasedVersion.majorVersion} + myReleasedVersion.minorVersion=${myReleasedVersion.minorVersion} + myReleasedVersion.incrementalVersion=${myReleasedVersion.incrementalVersion} + + + + + + + + + diff --git a/src/it/released-version/verify.groovy b/src/it/released-version/verify.groovy new file mode 100644 index 00000000..ddc8d26e --- /dev/null +++ b/src/it/released-version/verify.groovy @@ -0,0 +1,9 @@ +File file = new File( basedir, "build.log" ); +assert file.exists(); + +String text = file.getText("utf-8"); + +// its difficult to check the positove case with an existing released version in an IT - so currently we test only the case when no version is detected +assert text.contains("No released version found.") + +return true; diff --git a/src/main/java/org/codehaus/mojo/buildhelper/ReleasedVersionMojo.java b/src/main/java/org/codehaus/mojo/buildhelper/ReleasedVersionMojo.java index 9b8cbbf8..726681da 100644 --- a/src/main/java/org/codehaus/mojo/buildhelper/ReleasedVersionMojo.java +++ b/src/main/java/org/codehaus/mojo/buildhelper/ReleasedVersionMojo.java @@ -127,6 +127,9 @@ public void execute() defineVersionProperty( "buildNumber", releasedVersion.getBuildNumber() ); defineVersionProperty( "qualifier", releasedVersion.getQualifier() ); } + else { + getLog().debug("No released version found."); + } } catch ( ArtifactMetadataRetrievalException e ) From ccbfb61dd3f49d1b3e7930296fd3fa6a03324ac1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Veiko=20K=C3=A4=C3=A4p?= Date: Wed, 16 Oct 2019 10:44:36 +0300 Subject: [PATCH 2/2] Fix issue #81 (https://github.com/mojohaus/build-helper-maven-plugin/issues/81) (cherry picked from commit 0e55de7f2a05df145d135093201d0a4ded02e0de) --- .../java/org/codehaus/mojo/buildhelper/ReleasedVersionMojo.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/codehaus/mojo/buildhelper/ReleasedVersionMojo.java b/src/main/java/org/codehaus/mojo/buildhelper/ReleasedVersionMojo.java index 726681da..d1cee70c 100644 --- a/src/main/java/org/codehaus/mojo/buildhelper/ReleasedVersionMojo.java +++ b/src/main/java/org/codehaus/mojo/buildhelper/ReleasedVersionMojo.java @@ -92,7 +92,7 @@ private void defineVersionProperty( String name, int value ) public void execute() { org.apache.maven.artifact.Artifact artifact = - artifactFactory.createArtifact( getProject().getGroupId(), getProject().getArtifactId(), "", "", "" ); + artifactFactory.createArtifact( getProject().getGroupId(), getProject().getArtifactId(), getProject().getVersion(), "", "" ); try { ArtifactVersion releasedVersion = null;