Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Java 8 #3

Closed
AndrewJCarr opened this issue Aug 4, 2015 · 11 comments
Closed

Add support for Java 8 #3

AndrewJCarr opened this issue Aug 4, 2015 · 11 comments

Comments

@AndrewJCarr
Copy link

I'm uplifting a project to Java 1.8 and the clirr-maven-plugin is dying on me in the reporting section with the error:

[INFO] org.apache.bcel.classfile.ClassFormatException: Invalid byte tag in constant pool: 18

Stack trace: Gist

It appears that the Apache BCEL dependency needs to be updated to version 6.0 when it gets released.

I also downloaded the BCEL 6.0 snapshot version in consideration for release, managed the dependency version, and it succeeded to generate the report.

@AndrewJCarr
Copy link
Author

Note: After some further debugging, project-info-reports-plugin is pulling bcel in as a transitive dependency. Since clirr is declaring the dependency, it would override the project-info-reports-plugin.

@bokken
Copy link
Member

bokken commented Aug 4, 2015

Does anyone know bcel's release plan?

On Tue, Aug 4, 2015, 11:32 AM AndrewJCarr notifications@github.com wrote:

Note: After some further debugging, project-info-reports-plugin is pulling
bcel in as a transitive dependency. Since clirr is declaring the
dependency, it would override the project-info-reports-plugin.


Reply to this email directly or view it on GitHub
#3 (comment)
.

@AndrewJCarr
Copy link
Author

@LasneF
Copy link

LasneF commented Oct 14, 2015

any news from this as bcel has released its version https://github.com/apache/commons-bcel/releases

@user667
Copy link

user667 commented Nov 24, 2015

Replacing the explicit

<dependency>
  <groupId>org.apache.bcel</groupId>
  <artifactId>bcel</artifactId>
  <version>5.2</version>
</dependency>

with

<dependency>
    <groupId>com.google.code.findbugs</groupId>
    <artifactId>bcel-findbugs</artifactId>
    <version>6.0</version>
</dependency>

did the trick for me (see RichardWarburton/lambda-behave#31 (comment)). I wasn't able to find a non-RC version of above apache commons-bcel.

Any chance that Java8 compat. will make it into 2.8?

@klopfdreh
Copy link

klopfdreh commented May 3, 2016

May I ask if this is fixed with release 2.7? Apache Wicket (https://github.com/apache/wicket) uses clirr-maven-plugin and 8.0.0-M1 is going to be released, soon. It would be nice if we can update the plugin to get compatibility for Java 8, because this is also a requirement for Wicket 8. 👍

Corresponding ticket: https://issues.apache.org/jira/browse/WICKET-5836

@vmassol
Copy link

vmassol commented May 3, 2016

Hi @klopfdreh On the XWiki project (http://xwiki.org) we've switched to using revapi, see http://massol.myxwiki.org/xwiki/bin/view/Blog/ByeByeCLIRRWelcomeRevapi

@klopfdreh
Copy link

Hi @vmassol - thanks a lot for that hint - we are going to have a look at it.

@Mahoney
Copy link

Mahoney commented May 13, 2016

While this is in progress, is there any way to force v2.7 of the plugin to use com.google.code.findbugs:bcel-findbugs:6.0 rather than org.apache.bcel:bcel:5.2? I can include an extra dependency on the google version, but there's no tag within in the Maven model to allow me to exclude the apache one.

@NegatioN
Copy link

+1 to Mahoney's question.
Also, are there any estimates for when 2.8 is releasing?

@olamy olamy closed this as completed in 2a86b19 Jun 2, 2016
olamy added a commit that referenced this issue Jun 2, 2016
switch to a java 8 compatible version of bcel, fixes #3
@vmassol
Copy link

vmassol commented Jun 2, 2016

Cool!

Note that even though this issue is closed, it doesn't add support for Java 8 as the issue title claims ;) It just makes it not fail if you're under java 8 but use java 7 constructs.

As I mentioned above if you're look for java8 support consider using revapi or japicmp (see http://massol.myxwiki.org/xwiki/bin/view/Blog/ByeByeCLIRRWelcomeRevapi).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants