Add support for Java 8 #3

Closed
AndrewJCarr opened this Issue Aug 4, 2015 · 11 comments

Projects

None yet

8 participants

@AndrewJCarr

I'm uplifting a project to Java 1.8 and the clirr-maven-plugin is dying on me in the reporting section with the error:

[INFO] org.apache.bcel.classfile.ClassFormatException: Invalid byte tag in constant pool: 18

Stack trace: Gist

It appears that the Apache BCEL dependency needs to be updated to version 6.0 when it gets released.

I also downloaded the BCEL 6.0 snapshot version in consideration for release, managed the dependency version, and it succeeded to generate the report.

@AndrewJCarr

Note: After some further debugging, project-info-reports-plugin is pulling bcel in as a transitive dependency. Since clirr is declaring the dependency, it would override the project-info-reports-plugin.

@bokken
bokken commented Aug 4, 2015

Does anyone know bcel's release plan?

On Tue, Aug 4, 2015, 11:32 AM AndrewJCarr notifications@github.com wrote:

Note: After some further debugging, project-info-reports-plugin is pulling
bcel in as a transitive dependency. Since clirr is declaring the
dependency, it would override the project-info-reports-plugin.


Reply to this email directly or view it on GitHub
#3 (comment)
.

@LasneF
LasneF commented Oct 14, 2015

any news from this as bcel has released its version https://github.com/apache/commons-bcel/releases

@user667
user667 commented Nov 24, 2015

Replacing the explicit

<dependency>
  <groupId>org.apache.bcel</groupId>
  <artifactId>bcel</artifactId>
  <version>5.2</version>
</dependency>

with

<dependency>
    <groupId>com.google.code.findbugs</groupId>
    <artifactId>bcel-findbugs</artifactId>
    <version>6.0</version>
</dependency>

did the trick for me (see RichardWarburton/lambda-behave#31 (comment)). I wasn't able to find a non-RC version of above apache commons-bcel.

Any chance that Java8 compat. will make it into 2.8?

@klopfdreh
klopfdreh commented May 3, 2016 edited

May I ask if this is fixed with release 2.7? Apache Wicket (https://github.com/apache/wicket) uses clirr-maven-plugin and 8.0.0-M1 is going to be released, soon. It would be nice if we can update the plugin to get compatibility for Java 8, because this is also a requirement for Wicket 8. 👍

Corresponding ticket: https://issues.apache.org/jira/browse/WICKET-5836

@vmassol
vmassol commented May 3, 2016

Hi @klopfdreh On the XWiki project (http://xwiki.org) we've switched to using revapi, see http://massol.myxwiki.org/xwiki/bin/view/Blog/ByeByeCLIRRWelcomeRevapi

@klopfdreh

Hi @vmassol - thanks a lot for that hint - we are going to have a look at it.

@Mahoney
Mahoney commented May 13, 2016

While this is in progress, is there any way to force v2.7 of the plugin to use com.google.code.findbugs:bcel-findbugs:6.0 rather than org.apache.bcel:bcel:5.2? I can include an extra dependency on the google version, but there's no tag within in the Maven model to allow me to exclude the apache one.

@NegatioN

+1 to Mahoney's question.
Also, are there any estimates for when 2.8 is releasing?

@olamy olamy closed this in 2a86b19 Jun 2, 2016
@vmassol
vmassol commented Jun 2, 2016 edited

Cool!

Note that even though this issue is closed, it doesn't add support for Java 8 as the issue title claims ;) It just makes it not fail if you're under java 8 but use java 7 constructs.

As I mentioned above if you're look for java8 support consider using revapi or japicmp (see http://massol.myxwiki.org/xwiki/bin/view/Blog/ByeByeCLIRRWelcomeRevapi).

@sbordet sbordet added a commit to eclipse/jetty.project that referenced this issue Jun 13, 2016
@sbordet sbordet Temporarily commented out buggy clirr plugin. 4f0741a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment