Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Maven 3 APIs and Aether #326

Closed
srdo opened this issue Apr 20, 2019 · 3 comments · May be fixed by marcus-nl/camunda-bpm-platform#3
Closed

Upgrade to Maven 3 APIs and Aether #326

srdo opened this issue Apr 20, 2019 · 3 comments · May be fixed by marcus-nl/camunda-bpm-platform#3
Milestone

Comments

@srdo
Copy link
Contributor

@srdo srdo commented Apr 20, 2019

It would be good to upgrade to Maven 3 APIs and Aether. It is difficult to implement some features (programmatic dependency resolution for instance) correctly with the old APIs, and they are also deprecated in newer Maven versions.

The plugin could be upgraded to use Maven 3 dependencies, and maven-resolver (Aether).

srdo added a commit to srdo/license-maven-plugin that referenced this issue Apr 23, 2019
srdo added a commit to srdo/license-maven-plugin that referenced this issue Apr 23, 2019
srdo added a commit to srdo/license-maven-plugin that referenced this issue Apr 23, 2019
srdo added a commit to srdo/license-maven-plugin that referenced this issue Apr 23, 2019
@ppalaga ppalaga closed this in 340c0ec Apr 24, 2019
ppalaga added a commit that referenced this issue Apr 24, 2019
Fix #326 Migrate to using Maven 3 APIs and Aether for dependency resolution
@ppalaga ppalaga added this to the 2.0.0 milestone Jun 22, 2019
@brabenetz
Copy link

@brabenetz brabenetz commented Sep 24, 2019

Is the exact Maven Version "3.5.4" really needed?
I had a problem with Travis-CI which seems to use Version "3.5.2":
https://travis-ci.org/brabenetz/secured-properties/jobs/588693548

@srdo
Copy link
Contributor Author

@srdo srdo commented Sep 24, 2019

@brabenetz See #327. It's possible the plugin may work with 3.5.2. Oldest version tested was 3.5.4 through this repo's Travis setup. It's odd that yours is using an older Maven.

You could try reducing the version to 3.5.2 and see if the tests pass on version 3.5.2?

Alternatively you can upgrade Maven as part of your build, see https://github.com/apache/storm/blob/38b09fd229d2034a0fb6d5359eaa0b8ecdc0b61a/.travis.yml#L46

@brabenetz
Copy link

@brabenetz brabenetz commented Sep 24, 2019

@srdo
FYI, I found out why your build run with maven 3.5.4
You using "mvnw" script in your root-repo (travic-ci detects that and uses it), which will download the exact version 3.5.4 (This maybe slow down your build).

I will just wait until travis-ci updates there images, and update the license-maven-plugin later.
thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants